Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT][#3] 앱 메인 로고 추가 및 앱 타이틀 변경 #20

Merged
merged 2 commits into from
Jan 25, 2024
Merged

[FEAT][#3] 앱 메인 로고 추가 및 앱 타이틀 변경 #20

merged 2 commits into from
Jan 25, 2024

Conversation

josushell
Copy link
Member

@josushell josushell commented Jan 25, 2024 •
edited
Loading

  • 앱 메인 로고를 추가했습니다
  • 앱 타이틀을 변경했습니다

@josushell josushell added the feature New feature or request label Jan 25, 2024
@josushell josushell self-assigned this Jan 25, 2024
@josushell josushell requested a review from easyhooon January 25, 2024 08:09
easyhooon
easyhooon approved these changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@easyhooon easyhooon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ilab-android

오 잘 바뀐거 확인했어 app title 도 아이랩? I'Lab? 으로 바꿔놓는게 좋을 것 같은데 그건 다른 피처에서 하면 되려나

@josushell
Copy link
Member Author

josushell commented Jan 25, 2024 •
edited
Loading

오 잘 바뀐거 확인했어 app title 도 아이랩? I'Lab? 으로 바꿔놓는게 좋을 것 같은데 그건 다른 피처에서 하면 되려나

@easyhooon 오 그렇네 그러면 이름 바꾸는거 따로 피쳐 만들기 애매하니까 내가 이 pr에 커밋하나 새로 올릴까?

@easyhooon
Copy link
Collaborator

어 그게 좋을거같아

@josushell josushell changed the title [FEAT][#3] 앱 메인 로고 추가 [FEAT][#3] 앱 메인 로고 추가 및 앱 타이틀 변경 Jan 25, 2024
@easyhooon
Copy link
Collaborator

ilab-app-title
LGTM!

@josushell josushell merged commit f1eb6d3 into develop Jan 25, 2024
1 check passed
@josushell josushell deleted the feature/setAppIcon branch January 25, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easyhooon easyhooon easyhooon approved these changes

Assignees

@josushell josushell

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josushell @easyhooon