Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/#47] 태그 생성 기능 추가 #52

Merged
merged 1 commit into from
Feb 7, 2025
Merged

[Feature/#47] 태그 생성 기능 추가 #52

merged 1 commit into from
Feb 7, 2025

Conversation

lgrin-byte
Copy link
Member

💡 변경사항 & 이슈


태그 추가 시트에서 태그 추가할 수 있도록 함

✍️ 관련 설명

바깥쪽 눌러도 꺼지도록 나중에 모달 작업할 때 같이 해야할 것 같고
혹시 뒤로가기 눌렀을 때 선택한 태그, 추가한 태그 남아있으려면 전역 상태로 관리해야 할 것 같은데 이건 2차때 해도 될 거 같으!

⭐️ Review point

코드 개선점

📷 Demo


![스크린샷 2025-02-06 오후 3 02 27](https://github.com/user-attachments/assets/51ff4223-1a05-4e18-8833-27fdd9ae318a)

@lgrin-byte lgrin-byte requested a review from sikkzz as a code owner February 6, 2025 06:07
@lgrin-byte lgrin-byte linked an issue Feb 6, 2025 that may be closed by this pull request
1 task
@lgrin-byte lgrin-byte self-assigned this Feb 6, 2025
Copy link
Collaborator

@sikkzz sikkzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다음부터는 브랜치 네임 feat/#47 이런식으로 꼭 지어줘! 이게 git 명령어 시스템 구조상으로 #이 주석으로 인식되기 때문에 git checkout #47 이런식의 이동이 불가능하거든

나머지는 문제 없는 듯 고생했어~~

@lgrin-byte lgrin-byte closed this Feb 7, 2025
@lgrin-byte lgrin-byte deleted the #47 branch February 7, 2025 07:06
@lgrin-byte lgrin-byte restored the #47 branch February 7, 2025 07:07
@lgrin-byte
Copy link
Member Author

엇 그러게 왜 feat빠트렸지 ㅋㅋㅋ

@lgrin-byte lgrin-byte reopened this Feb 7, 2025
@lgrin-byte lgrin-byte merged commit 82fa4f6 into develop Feb 7, 2025
4 checks passed
@lgrin-byte lgrin-byte deleted the #47 branch February 7, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] 태그 생성 기능 추가
2 participants