Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Workaround empty Trigger Request deserialization issue #1

Conversation

leonmceniery
Copy link

Workaround found here: Unity-Technologies/Unity-Robotics-Hub#390 (comment)

Looks good for now until we can move away from Unity Robotics packages.

Copy link

@sven-hoek sven-hoek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aw man...so I guess If we ever would want to send SnowtocolPing, SnowtocolGetDeviceInfo or SnowtocolResetParams from the UI, we'd need to add something in here, too? 😞
(They also have empty requests)

@leonmceniery
Copy link
Author

Aw man...so I guess If we ever would want to send SnowtocolPing, SnowtocolGetDeviceInfo or SnowtocolResetParams from the UI, we'd need to add something in here, too? 😞 (They also have empty requests)

YEP!! But I think if we run into this again is open up their deserializer and fix the issue under the hood

@leonmceniery leonmceniery merged commit 1a533d6 into dev-nexxis Nov 25, 2024
@leonmceniery leonmceniery deleted the bugfix/leon/Workaround-empty-service-request-deserialization-issue branch November 25, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants