Skip to content

Commit

Permalink
add:code_quality.yml
Browse files Browse the repository at this point in the history
add:review.yml
chore:ci.yml -> angular_build.yml
  • Loading branch information
mzkmnk committed Jan 4, 2025
1 parent f3d1a2a commit 37fab66
Show file tree
Hide file tree
Showing 4 changed files with 52 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ on:

jobs:
build:
permissions:
contents: read
pull-requests: write

runs-on: ubuntu-latest

Expand All @@ -15,7 +18,7 @@ jobs:

steps:
- name: repository checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: node.js setup
uses: actions/setup-node@v3
Expand All @@ -33,7 +36,7 @@ jobs:
- name: dependency install
run: npm ci

- name: testing
- name: angular test
run: npm run test

- name: angular building
Expand Down
21 changes: 21 additions & 0 deletions .github/workflows/code_quality.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
name: Code quality

on:
pull_request:
types:
- opened
- ready_for_review
- synchronize

jobs:
quality:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Setup Biome
uses: biomejs/setup-biome@v2
with:
version: latest
- name: Run Biome
run: biome ci ./projects/ngrx-extension/src
24 changes: 24 additions & 0 deletions .github/workflows/review.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: reviewdog
on:
pull_request:
types:
- opened
- ready_for_review
- synchronize
jobs:
biome:
name: runner / Biome
runs-on: ubuntu-latest
permissions:
contents: read
pull-requests: write
steps:
- uses: actions/checkout@v4
- uses: mongolyy/reviewdog-action-biome@v1
with:
github_token: ${{ secrets.github_token }}
reporter: github-pr-review
level: error
filter_mode: nofilter
fail_on_error: true
biome_flags: './projects/ngrx-extension/src'
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ import { TestBed } from '@angular/core/testing';
import { getState, patchState, signalStore, withState } from '@ngrx/signals';
import { withStorageSync } from './with-storage-sync';

describe('withStorageSync', () => {
// todo
describe('withStorageSync test', () => {
beforeEach(() => {
localStorage.clear();
});
Expand Down

0 comments on commit 37fab66

Please sign in to comment.