[feat]biome CI

.github/workflows/ci.yml → .github/workflows/angular_build.yml

@@ -6,6 +6,9 @@ on:
 
 jobs:
   build:
+    permissions:
+      contents: read
+      pull-requests: write
 
     runs-on: ubuntu-latest
 
@@ -15,7 +18,7 @@ jobs:
 
     steps:
       - name: repository checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: node.js setup
         uses: actions/setup-node@v3
@@ -33,7 +36,7 @@ jobs:
       - name: dependency install
         run: npm ci
 
-      - name: testing
+      - name: angular test
         run: npm run test
 
       - name: angular building

.github/workflows/code_quality.yml

@@ -0,0 +1,21 @@
+name: Code quality
+
+on:
+  pull_request:
+    types:
+      - opened
+      - ready_for_review
+      - synchronize
+
+jobs:
+  quality:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+      - name: Setup Biome
+        uses: biomejs/setup-biome@v2
+        with:
+          version: latest
+      - name: Run Biome
+        run: biome ci ./projects/ngrx-extension/src

.github/workflows/review.yml

@@ -0,0 +1,24 @@
+name: reviewdog
+on:
+  pull_request:
+    types:
+      - opened
+      - ready_for_review
+      - synchronize
+jobs:
+  biome:
+    name: runner / Biome
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      pull-requests: write
+    steps:
+      - uses: actions/checkout@v4
+      - uses: mongolyy/reviewdog-action-biome@v1
+        with:
+          github_token: ${{ secrets.github_token }}
+          reporter: github-pr-review
+          level: error
+          filter_mode: nofilter
+          fail_on_error: true
+          biome_flags: './projects/ngrx-extension/src'

biome.json

@@ -19,7 +19,12 @@
 	"linter": {
 		"enabled": true,
 		"rules": {
-			"recommended": true
+			"recommended": true,
+			"complexity": {
+				"noBannedTypes": {
+					"level": "off"
+				}
+			}
 		}
 	},
 	"javascript": {

projects/ngrx-extension/src/lib/with-storage-sync/with-storage-sync.spec.ts

@@ -80,7 +80,7 @@ describe('withStorageSync', () => {
 				...initialAppState,
 				products: {
 					...initialAppState.products,
-					items: JSON.parse(localStorage.getItem('products-items')!),
+					items: JSON.parse(localStorage.getItem('products-items') ?? '[]'),
 				},
 			});
 		});
@@ -149,7 +149,7 @@ describe('withStorageSync', () => {
 				...initialAppState,
 				products: {
 					...initialAppState.products,
-					items: JSON.parse(localStorage.getItem('products-items')!),
+					items: JSON.parse(localStorage.getItem('products-items') ?? '[]'),
 				},
 			});
 		});
@@ -210,7 +210,9 @@ describe('withStorageSync', () => {
 				...initialAppState,
 				products: {
 					...initialAppState.products,
-					items: JSON.parse(localStorage.getItem(`${prefix}-products-items`)!),
+					items: JSON.parse(
+						localStorage.getItem(`${prefix}-products-items`) ?? '[]',
+					),
 				},
 			});
 		});

projects/ngrx-extension/src/lib/with-storage-sync/with-storage-sync.ts

@@ -54,7 +54,7 @@ export function withStorageSync({
 					prefix,
 					(key, fullKeyPath, objectState) => {
 						// If the store does not have the specified key
-						if (!(objectState as Record<string, object>).hasOwnProperty(key)) {
+						if (!Object.hasOwn(objectState as Record<string, object>, key)) {
 							throw new Error(`[${key}] ${key} not found`);
 						}
 
@@ -131,7 +131,7 @@ function writeDfs(
 	prefix: string,
 	callback: (key: string, fullKeyPath: string, objectState: unknown) => void,
 ): void {
-	nodes.forEach((node) => {
+	for (const node of nodes) {
 		if (typeof node === 'string') {
 			const fullKeyPath = prefix === '' ? node : `${prefix}-${node}`;
 			// If the current node is the end, call the callback to write data to storage
@@ -144,7 +144,7 @@ function writeDfs(
 				writeDfs(nestedState, childNode, newPrefix, callback);
 			}
 		}
-	});
+	}
 }
 
 /**
@@ -160,7 +160,7 @@ function readDfs(
 	prefix: string,
 	callback: (fullKeyPath: string) => void,
 ): void {
-	nodes.forEach((node) => {
+	for (const node of nodes) {
 		if (typeof node === 'string') {
 			const fullPathKey = prefix === '' ? node : `${prefix}-${node}`;
 			callback(fullPathKey);
@@ -170,7 +170,16 @@ function readDfs(
 				readDfs(childNode, newPrefix, callback);
 			}
 		}
-	});
+		if (typeof node === 'string') {
+			const fullPathKey = prefix === '' ? node : `${prefix}-${node}`;
+			callback(fullPathKey);
+		} else {
+			for (const [key, childNode] of Object.entries(node)) {
+				const newPrefix = prefix === '' ? key : `${prefix}-${node}`;
+				readDfs(childNode, newPrefix, callback);
+			}
+		}
+	}
 }
 
 /**