Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: string to runes fix emoji length #14

Merged
merged 2 commits into from
Jul 13, 2024
Merged

fix: string to runes fix emoji length #14

merged 2 commits into from
Jul 13, 2024

Conversation

Muzm
Copy link
Contributor

@Muzm Muzm commented Jul 9, 2024

image

if TextWriter.text contain emoji, String.substring method will cause the error below, use String.runes.sublist instead.

Invalid argument(s): string is not well-formed UTF-16

@Muzm
Copy link
Contributor Author

Muzm commented Jul 11, 2024

fixed rune bugs. and test/typewriter_value_test.dartfirst example add emoji icon '👑', all test passed locally

@Nialixus Nialixus merged commit d3a5186 into Nialixus:master Jul 13, 2024
2 checks passed
@Nialixus Nialixus added the enhancement New feature or request label Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Muzm Muzm

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Muzm @Nialixus