Fix issue160 #192
Open
Fix issue160 #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by pip install .
This reverts commit a2c943d.
|
@Thomasb81, Looks good, tests are failing because of some dependency is not yet updated. |
Nic30
reviewed
Aug 26, 2024
| #auditwheel repair --plat manylinux_2_31_x86_64 dist/*.whl | ||
| pip install . | ||
| python setup.py bdist_wheel -j 4 | ||
| auditwheel repair --plat manylinux_2_31_x86_64 dist/*.whl |
There was a problem hiding this comment.
Can you add comment why did you pick manylinux_2_31_x86_64 (perhaps link on original from where this was taken)
There was a problem hiding this comment.
Sorry I can't.
My initial commit change this .github/workflow/build_and_release.yml file then I revert it, in the latest commit. So I guess you are the original author of this setting.
Any details instruction for this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #160 by adding hierarchical_identifier as alternative in delay_value rule
Please indicate how to add tests to the testsuite. I have 2 tests to add.