-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features and Fixes Part 2 #377
Conversation
@kissthermite Just a note, the format string used for file name to tag will be remembered independently of that used by tag to file name. Once you download and extract the
Once you've tested and are done with it (or you can keep using it until the next beta release) you can uninstall it with:
Feel free to comment with any issues, comments, questions, or concerns :)) |
It does remember my custom format string even after closing Tagger. Such a nice QOL. Good job @nlogozzo! |
@kissthermite Glad everything works as expected :) This build should contain the fix for Once you confirm that works I will merge this PR and release RC1 and we should be all good for a stable release on Friday! |
it worked! 🚀 I just realized that there's currently no way to remove |
Yay!! I have to go to work now but once I get home later td I'll merge and do a release :) |
I just edited my comment in case you didn't see it.
That trash can button can be seen on |
Ah, good idea! Will implement that when I get home instead |
@kissthermite Ok, done! Use this build to test: https://github.com/NickvisionApps/Tagger/actions/runs/6605232433 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should take disc number to consideration everywhere where we compare track numbers: for sorting by artist, year and genre too.
Done in latest commit! |
@nlogozzo another job completed fantastically! |
@kissthermite RC1 will come in a little bit. Just be advised that configurations are kept independent of branches. Meaning flatpak beta and flatpak master will be different. So upon installing rc1, your format string won't be remembered until you use it for the first time on the version. |
Why is that? Flatpak data dir is always |
I could be wrong. I thought the whole branch was kept separate from each other. Guess it's just the binaries and the rest is shared. |
Closes #363
Closes #365
Closes #375
Blocking: