-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes + Tweaks #396
Fixes + Tweaks #396
Conversation
@kissthermite Could you test this build: https://github.com/NickvisionApps/Tagger/actions/runs/6776895782 |
sure! will let you know in a moments |
Well now with the new algorithm I think I can do that. |
Correct indeed. |
@kissthermite P.S. Thanks for testing and sorry for messing up your library structure with these tests 🫠 |
Sorry I lied, please try this build: https://github.com/NickvisionApps/Tagger/actions/runs/6779656223 If a tag property contains |
Just tested and indeed it does behave the way you said whether |
Yay, glad it's working as expected now! Once @fsobolev approves of the rest of this PR, I will release a beta. If you have any other issues/feature requests please try to report them before Wednesday that way I can implement them all on Wednesday and then get a stable out by Friday 😅 |
Hmm...no it's not intended. Will take a look at it tomorrow to see what's going on. |
@kissthermite Can't reproduce... I think it just seems every small in GNOME but the space is indeed there. |
Yeah. My bad just check it again and indeed it's just a very tiny space. |
I was going to release a beta but decided against it since it's almost Friday and if any bugs come up before then I will fix them and just release stable. Since your issue was confirmed to be fixed, no need for a beta. |
Fixes #395
TODO:
WinUI Tweaks: