Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNOME 45 Port #406

Merged
merged 15 commits into from
Nov 15, 2023
Merged

GNOME 45 Port #406

merged 15 commits into from
Nov 15, 2023

Conversation

nlogozzo
Copy link
Member

@nlogozzo nlogozzo commented Nov 14, 2023

Closes #401

Folder Open, No Files Found:
image

Folder Open, With Files, No Selection:
image

Folder Open, With Files, Selection:
image

Folder Open, With Files, Selection, Sidebar Collapsed:
image

@nlogozzo nlogozzo marked this pull request as ready for review November 14, 2023 02:38
@nlogozzo
Copy link
Member Author

@DaPigGuy I think I did the new widgets right on MainWindow 😅

Copy link
Member

@DaPigGuy DaPigGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit

NickvisionTagger.GNOME/Views/MainWindow.cs Outdated Show resolved Hide resolved
@DaPigGuy
Copy link
Member

DaPigGuy commented Nov 14, 2023

The sidebar doesn't seem to collapse properly on shrinking the window due to a missing minimum width (width-request)

@nlogozzo
Copy link
Member Author

The sidebar doesn't seem to collapse properly on shrinking the window due to a missing minimum width (width-request)

The sidebar has:

sidebar: Gtk.Box {
              width-request: 400;

@nlogozzo
Copy link
Member Author

@DaPigGuy I realized what I was doing wrong...fixed in latest commit

@nlogozzo nlogozzo requested review from DaPigGuy and removed request for DaPigGuy November 14, 2023 23:47
@nlogozzo nlogozzo merged commit 307ca9f into main Nov 15, 2023
@nlogozzo nlogozzo deleted the 45 branch November 15, 2023 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GNOME 45
2 participants