Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] ENH : first pass a getting import hooks to work #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] ENH : first pass a getting import hooks to work #37

wants to merge 1 commit into from

Conversation

tacaswell
Copy link
Member

Does some magic to hide the fact that we are importing from a yaml file.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 15c53f5 on tacaswell:import_hooks into 1ace9f3 on Nikea:master.

@tacaswell tacaswell changed the title ENH : first pass a getting import hooks to work [WIP] ENH : first pass a getting import hooks to work Dec 7, 2014
ericdill
ericdill reviewed Dec 8, 2014
View reviewed changes
vt_config/NSLS-II/init.py
name = fullname.rpartition('.')[-1]
if path is None:
path = self._path
for dn in path:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dn stands for what?

@ericdill
Copy link
Contributor

ericdill commented Dec 9, 2014

Thought I assume you already know this, vistrails is raising AssertionErrors on the isinstance(x, str) tests in /VisTrails/vistrails/core/modules/basic_modules.py. I'm mostly writing this down so that others are aware this is a known issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tacaswell @coveralls @ericdill