Add consistent testing

.github/workflows/publish-results.yml

@@ -0,0 +1,13 @@
+# Needed to publish test results in fork
+name: Testing Callback
+
+on:
+  workflow_run:
+    workflows: ["PR Testing"]
+    types:
+      - completed
+
+jobs:
+  call-reusable-workflow:
+    name: Call Reusable Testing Callback Workflow
+    uses: NilFoundation/ci-cd/.github/workflows/reusable-crypto3-publish-result.yml@v1

.github/workflows/pull-request.yml

@@ -0,0 +1,24 @@
+name: PR Testing
+
+on:
+  pull_request:
+    types:
+      - opened
+      - synchronize
+
+jobs:
+  handle-syncwith:
+    name: Call Reusable SyncWith Handler
+    uses: NilFoundation/ci-cd/.github/workflows/reusable-handle-syncwith.yml@v1
+    with:
+      ci-cd-ref: 'v1'
+    secrets: inherit
+
+  matrix-test:
+    name: Call Reusable Crypto3 Testing
+    needs:
+      - handle-syncwith
+    uses: NilFoundation/ci-cd/.github/workflows/reusable-crypto3-testing.yml@v1
+    with:
+      submodules-refs: ${{ needs.handle-syncwith.outputs.prs-refs }}
+    secrets: inherit

test/CMakeLists.txt

@@ -20,29 +20,43 @@ cm_test_link_libraries(${CMAKE_WORKSPACE_NAME}_${CURRENT_PROJECT_NAME}
 
 
 macro(define_runtime_algebra_test name)
-    cm_test(NAME algebra_${name}_test SOURCES ${name}.cpp)
+    set(test_name "algebra_${name}_test")
 
-    target_include_directories(algebra_${name}_test PRIVATE
+    set(additional_args "")
+    if(ENABLE_JUNIT_TEST_OUTPUT)
+        set(TEST_RESULTS_DIR "${CMAKE_CURRENT_BINARY_DIR}/junit_results")
+        set(TEST_LOGS_DIR "${TEST_RESULTS_DIR}/logs")
+        file(MAKE_DIRECTORY ${TEST_LOGS_DIR})
+
+        set(additional_args "--log_format=JUNIT"
+                            "--log_sink=${TEST_LOGS_DIR}/${test_name}.xml")
+    endif()
+
+    cm_test(NAME ${test_name} SOURCES ${name}.cpp ARGS ${additional_args})
+
+    target_include_directories(${test_name} PRIVATE
                                "$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>"
                                "$<BUILD_INTERFACE:${CMAKE_BINARY_DIR}/include>"
 
                                ${Boost_INCLUDE_DIRS})
 
-    set_target_properties(algebra_${name}_test PROPERTIES CXX_STANDARD 17
+    set_target_properties(${test_name} PROPERTIES CXX_STANDARD 17
         CXX_STANDARD_REQUIRED TRUE)
 
     get_target_property(target_type Boost::unit_test_framework TYPE)
     if(target_type STREQUAL "SHARED_LIB")
-        target_compile_definitions(algebra_${name}_test PRIVATE BOOST_TEST_DYN_LINK)
+        target_compile_definitions(${test_name} PRIVATE BOOST_TEST_DYN_LINK)
     elseif(target_type STREQUAL "STATIC_LIB")
 
     endif()
 
     if (CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
-        target_compile_options(algebra_${name}_test PRIVATE "-fconstexpr-steps=2147483647")
+        target_compile_options(${test_name} PRIVATE "-fconstexpr-steps=2147483647")
     elseif (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
-        target_compile_options(algebra_${name}_test PRIVATE "-fconstexpr-ops-limit=4294967295")
+        target_compile_options(${test_name} PRIVATE "-fconstexpr-ops-limit=4294967295")
     endif()
+
+    target_compile_definitions(${test_name} PRIVATE TEST_DATA_DIR="${CMAKE_CURRENT_SOURCE_DIR}/data/")
 endmacro()
 
 macro(define_compile_time_algebra_test name)
@@ -72,7 +86,6 @@ set(RUNTIME_TESTS_NAMES
     "fields_static"
     "pairing"
     "hash_to_curve"
-    "wnaf"
     "multiexp"
     )
 

test/curves.cpp

@@ -180,7 +180,7 @@ namespace boost {
 }    // namespace boost
 
 // if target == check-algebra just data/curves.json
-const char *test_data = "../../../../libs/algebra/test/data/curves.json";
+std::string test_data = std::string(TEST_DATA_DIR) + R"(curves.json)";
 
 boost::property_tree::ptree string_data(std::string test_name) {
     boost::property_tree::ptree string_data;
@@ -236,11 +236,11 @@ void check_curve_operations(const std::vector<typename CurveGroup::value_type> &
     BOOST_CHECK_EQUAL(result, points[p1_minus_p2]);
 
     result = points[p1];
-    result *= static_cast<cpp_int>(constants[C1]); 
+    result *= static_cast<cpp_int>(constants[C1]);
     BOOST_CHECK_EQUAL(result, points[p1_mul_C1]);
 
     result = points[p2];
-    result *= static_cast<cpp_int>(constants[C1]); 
+    result *= static_cast<cpp_int>(constants[C1]);
     result += points[p2] * static_cast<cpp_int>(constants[C2]);
     BOOST_CHECK_EQUAL(result, points[p2_mul_C1_plus_p2_mul_C2]);
 }
@@ -278,11 +278,11 @@ void check_curve_operations_twisted_edwards(
     BOOST_CHECK_EQUAL(result, points[p1_minus_p2]);
 
     result = points[p1];
-    result *= static_cast<cpp_int>(constants[C1]); 
+    result *= static_cast<cpp_int>(constants[C1]);
     BOOST_CHECK_EQUAL(result, points[p1_mul_C1]);
 
     result = points[p2];
-    result *= static_cast<cpp_int>(constants[C1]); 
+    result *= static_cast<cpp_int>(constants[C1]);
     result += points[p2] * static_cast<cpp_int>(constants[C2]);
     BOOST_CHECK_EQUAL(result, points[p2_mul_C1_plus_p2_mul_C2]);
 }