Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change boolattr to just always write out #583

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

locallycompact
Copy link

No description provided.

@locallycompact locallycompact changed the title Use attr instead of boolattr for enableLibraryProfiling and enableExecutableProfiling Change boolattr to just always write out Oct 31, 2022
@sternenseemann
Copy link
Member

I expect this will quite significantly inflate the size of the already huge hackage-packages.nix in nixpkgs, so it may not be a good idea even though it has some merits.

@locallycompact
Copy link
Author

locallycompact commented Nov 1, 2022

Can we make it so the writer can be injected into cabal2nix'' somehow? I'm using it via library call.

@sternenseemann
Copy link
Member

I don't understand what you mean, could you clarify?

@locallycompact
Copy link
Author

The Pretty Derivation instance I can't alter without forking. Maybe this should not be an instance, but an explicit parameter to cabal2nix' instead. Then I can define my own pretty function for Derivation that does what I want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants