Fetch remote tarballs/zips using nix-prefetch-url --unpack
#585
Conversation
Fetching `tar.gz` files is common enough of a use-case that warrants treating them specially by bypassing other fetching options and using `nix-prefetch-url --unpack` directly. This speeds up large tarballs as `cabal2nix` currently downloads them twice as the first fetch assumes an unpacked url and thus will fail.
pwm
force-pushed
the
pwm/tarball-fetch
branch
from
ccedf3d
to
34fbe05
Compare
pwm
changed the title
.tar.gz using nix-prefetch-url --unpacknix-prefetch-url --unpack
There was a problem hiding this comment.
I am not a regular cabal2nix contributor, but I saw your discussion on the matrix channel. Here are my two cents:
I think the fetchPackedUrl function needs a top level comment explaining why it was added.
Aslo, I think the process function should be top-leveled and reused (by fetch and fetchPackedUrl).
|
@dschrempf thanks for the feedback
Agreed, will add.
I actually did that first but then thought it might be better to try and minimise the change which is why i did it this way. Happy to lift it out (I think it makes sense) but that will mean a slightly bigger PR (not sure if that's an issue though). |
Fetching remote tarballs/zips is common enough of a use-case that warrants treating them specially by bypassing other fetching options and going for
nix-prefetch-url --unpackdirectly. This speeds up large tarballs ascabal2nixcurrently downloads them twice, where the first fetch assumes an unpacked url and thus fails.