CompressLog: Add zstd compression #1404
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
commented
Aug 21, 2024
| my $doTail = $tail ? "| tail -n '$tail'" : ""; | ||
| open($fh, "-|", "bzip2 -dc < '$logPath' $doTail") or die; | ||
| if ($logPath =~ /\.zst$/) { | ||
| open($logFh, "-|", "zstd", "-dc", $logPath) or die; |
There was a problem hiding this comment.
@SuperSandro2000 sorry, I got nerd snipped, when seeing shells being spawned with external inputs. Could you test this variant?
Mic92
force-pushed
the
feat/buildlogs-zstd
branch
from
52843dc
to
5d53ee2
Compare
In the common case we just read 50 lines so it seems wasteful to shell out. Also makes the decompression code a bit more readable.
Mic92
force-pushed
the
feat/buildlogs-zstd
branch
from
5d53ee2
to
0a7dc7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.