Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Nix::Store and Nix::Utils in NARInfo.pm #1405

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

hacker1024
Copy link
Member

@hacker1024 hacker1024 commented Aug 21, 2024

These are required for some subroutines used when signing NARs. They were erroneously removed in #1359.

Without this change, and with binary_cache_secret_key_file defined, when requesting a .narinfo:

Caught exception in Hydra::View::NARInfo->process "Can't locate object method "readFile" via package "/path/to/secret-key" (perhaps you forgot to load "/path/to/secret-key"?) at /nix/store/j1j3fyxwlbgkxczm6kr62nhkxw21xjnp-hydra-2024-07-09/libexec/hydra/lib/Hydra/View/NARInfo.pm line 39."
Caught exception in Hydra::View::NARInfo->process "Undefined subroutine &Hydra::View::NARInfo::signString called at /nix/store/g5w3py1ik48lgjql0fw45pvs3yi55g1h-hydra-2024-07-09/libexec/hydra/lib/Hydra/View/NARInfo.pm line 42."

These are required for the `signString` and `readFile` subroutines used when signing NARs.
@hacker1024 hacker1024 changed the title Use Nix::Utils in NARInfo.pm Use Nix::Store and Nix::Utils in NARInfo.pm Aug 25, 2024
@Mic92 Mic92 merged commit b1a0501 into NixOS:master Aug 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants