Non-content edits to pills 9-14 #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-mlabs
changed the title
peter-mlabs
changed the title
|
What's the status of this PR ? I personally like the changes. |
|
Only glanced over it, but looks fine to merge if conflicts are resolved. (My mobile view thinks there are some left, maybe it's wrong.) |
fricklerhandwerk
approved these changes
Feb 9, 2024
|
Thanks @henrik-ch for keeping things moving! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (and future PRs I'll be submitting in the same vein) is focused on improving grammar, voicing, stylistic consistency, and readability. As a relatively inexperienced Nix user, I don't have much to add in terms of content or technical commentary; I'd simply like to improve the quality of the existing documentation.
I've found that the earlier pills have a slightly different tone than the later pills -- some of which almost seems like it can be attributed to different authors -- and that the writing style becomes weaker as the material grows in complexity. As such, I only committed to undertaking this editing starting at pill #9 (the point at which I felt my own comprehension beginning to suffer), and I plan on editing as I go through the remaining pills. Once I'm finished, I'll try to go back and revise from the beginning.