-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treewide: Format all Nix code according to RFC-166 #232
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I don't like one of the changes.
This comment was marked as resolved.
This comment was marked as resolved.
pills/17/config-nix.txt
Outdated
@@ -1,5 +1,8 @@ | |||
{ | |||
packageOverrides = pkgs: { | |||
graphviz = pkgs.graphviz.override { withXorg = false; }; | |||
graphviz = pkgs.graphviz.override { | |||
# enable xorg support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be disable xorg support
@dasJ, thank you for the comprehensive update to the repo's formatting—great work, especially given the scope! Apologies for chiming in a bit late on this. To ensure consistency in future updates and avoid inadvertently diverging from the new standard, could you share the specific command or process you employed for this reformatting? I'm assuming there was some automation involved rather than manual adjustments? I attempted to replicate the formatting on my end, targeting a pre-update version of the repo, using:
However, this only resulted in changes to a select few files within pill 20, as indicated by my git status output below:
Please could you share the correct approach or any insights into the process you used. Many thanks in advance! 🙏 |
Unfortunately, the nix code is not actually in Also, the soon-to-be default formatter for nixpkgs will be nixfmt, not nixpkgs-fmt (I know the name is confusing). The new formatter is packaged in nixpkgs right now as I know it's a mess right now but there is ongoing work to clean this up :) |
No description provided.