Acknowledge efforts to port the pills to its current format #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
DocBook should be capitalized like this.
…On Mon, Apr 8 2024 at 16:49:44 -07:00:00, Daniel Sidhion ***@***.***> wrote:
Important to acknowledge all the work that went into the port!
cc @noamraph @jtojnar let me know if you don't want to be credited
directly
You can view, comment on, or merge this pull request online at:
#234
Commit Summary
e4b6bea Acknowledge efforts to port the pills to its current format
File Changes (1 file)
M pills/00-preface.md (9)
Patch Links:
https://github.com/NixOS/nix-pills/pull/234.patch
https://github.com/NixOS/nix-pills/pull/234.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
DanielSidhion
force-pushed
the
acknowledge-new-changes
branch
from
e4b6bea
to
ee79346
Compare
noamraph
reviewed
Apr 9, 2024
|
Thank you @DanielSidhion ! I'm honored to be credited, and I'm happy that @jtojnar is credited as well for his hard work. |
DanielSidhion
force-pushed
the
acknowledge-new-changes
branch
from
ee79346
to
4d02f80
Compare
drupol
reviewed
Apr 13, 2024
DanielSidhion
force-pushed
the
acknowledge-new-changes
branch
from
4d02f80
to
782146b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important to acknowledge all the work that went into the port!
cc @noamraph @jtojnar let me know if you don't want to be credited directly