fetchClosure: Skip makeContentAddressed() if toPath is already valid

NixOS · Mar 24, 2022 · 7ffda0a · 7ffda0a
1 parent 5acaf13
commit 7ffda0a
Showing 1 changed file with 22 additions and 20 deletions.
diff --git a/src/libexpr/primops/fetchClosure.cc b/src/libexpr/primops/fetchClosure.cc
@@ -54,26 +54,28 @@ static void prim_fetchClosure(EvalState & state, const Pos & pos, Value * * args
     auto fromStore = openStore(*fromStoreUrl);
 
     if (toCA) {
-        auto remappings = makeContentAddressed(*fromStore, *state.store, { *fromPath });
-        auto i = remappings.find(*fromPath);
-        assert(i != remappings.end());
-        if (toPath && *toPath != i->second)
-            throw Error({
-                .msg = hintfmt("rewriting '%s' to content-addressed form yielded '%s', while '%s' was expected",
-                    state.store->printStorePath(*fromPath),
-                    state.store->printStorePath(i->second),
-                    state.store->printStorePath(*toPath)),
-                .errPos = pos
-            });
-        if (!toPath)
-            throw Error({
-                .msg = hintfmt(
-                    "rewriting '%s' to content-addressed form yielded '%s'; "
-                    "please set this in the 'toPath' attribute passed to 'fetchClosure'",
-                    state.store->printStorePath(*fromPath),
-                    state.store->printStorePath(i->second)),
-                .errPos = pos
-            });
+        if (!toPath || !state.store->isValidPath(*toPath)) {
+            auto remappings = makeContentAddressed(*fromStore, *state.store, { *fromPath });
+            auto i = remappings.find(*fromPath);
+            assert(i != remappings.end());
+            if (toPath && *toPath != i->second)
+                throw Error({
+                    .msg = hintfmt("rewriting '%s' to content-addressed form yielded '%s', while '%s' was expected",
+                        state.store->printStorePath(*fromPath),
+                        state.store->printStorePath(i->second),
+                        state.store->printStorePath(*toPath)),
+                    .errPos = pos
+                });
+            if (!toPath)
+                throw Error({
+                    .msg = hintfmt(
+                        "rewriting '%s' to content-addressed form yielded '%s'; "
+                        "please set this in the 'toPath' attribute passed to 'fetchClosure'",
+                        state.store->printStorePath(*fromPath),
+                        state.store->printStorePath(i->second)),
+                    .errPos = pos
+                });
+        }
     } else {
         copyClosure(*fromStore, *state.store, RealisedPath::Set { *fromPath });
         toPath = fromPath;