Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for RFC 133: Git hashing and Git-hashing-based remote stores #8919

Open
Ericson2314 opened this issue Sep 4, 2023 · 3 comments
Labels
RFC Related to an accepted RFC

Comments

@Ericson2314
Copy link
Member

Ericson2314 commented Sep 4, 2023

Info

Steps

Preperatory

Feature itself

@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nixcon-governance-workshop/32705/9

@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/obsidian-systems-is-excited-to-bring-ipfs-support-to-nix/7375/65

@roberth
Copy link
Member

roberth commented May 2, 2024

Idea:

  1. Store Object =~ Name + File System Object:
  2. Git hashing can not hash an executable blob
  3. Store Object =~ single-item Git directory (which includes the Name)

I know you don't like Name, but maybe this is helpful.

File under storeDir bad, name as directory?

Another idea is maybe paths should have been $storeDir/$hash/$name/$fhsLikeStuffOrWhatever. It'd prevent things like cp ${fooScript} $out/bin producing a command containing a hash, but it's not the only way to do it, and probably a little bit slower than the current store path format, and not worth the effort to make such a change. That specific problem is solved more easily by making Nixpkgs produce directories, and making writeScript return an outPath of "${drv.outPath}/bin/${name}".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC Related to an accepted RFC
Projects
None yet
Development

No branches or pull requests

3 participants