Improve git-hashing/simple.sh test
#10310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I realized it was checking NAR hashes before of added objects, which makes little sense --- we don't really care about ancillary NAR hashes. Now, the bottom `nix store add` tests compare the CA field with a git hash to hashes calculated by Git. This matches top `nix hash path` ones in using git as a source of truth.
github-actions
bot
added
the
with-tests
Ericson2314
changed the title
git-hashing/simple.shgit-hashing/simple.sh test
roberth
approved these changes
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I realized it was checking NAR hashes before of added objects, which makes little sense --- we don't really care about ancillary NAR hashes.
Now, the bottom
nix store addtests compare the CA field with a git hash to hashes calculated by Git. This matches topnix hash pathones in using git as a source of truth.Context
#8919
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.