Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

builtins.pathExists returns false on symlinks that point to non-existent paths #9901

Closed
infinisil opened this issue Feb 1, 2024 · 4 comments · Fixed by #9985
Closed

builtins.pathExists returns false on symlinks that point to non-existent paths #9901

infinisil opened this issue Feb 1, 2024 · 4 comments · Fixed by #9985
Assignees
@roberth
Labels
bug regression Something doesn't work anymore

Comments

@infinisil
Copy link
Member

infinisil commented Feb 1, 2024 •
edited
Loading

Describe the bug

On master, builtins.pathExists returns false for an existing symlink that points to a non-existent path.

This is a regression, as Nix 2.18.1 returns true.

Steps To Reproduce

$ ln -s does-not-exist symlink
$ nix-instantiate --eval -E 'builtins.pathExists ./symlink'
false

Expected behavior

The same as Nix 2.18.1, which is true

nix-env --version output

nix-env (Nix) 2.21.0pre20240201_ef6d055

Additional context

This was found from the lib.fileset test suite in Nixpkgs failing in a PR (NixOS/nixpkgs#285264), after which @roberth opened #9900.

This may relate to previous regressions:

This issue is sponsored by Antithesis ✨

Priorities

Add 👍 to issues you find important.
@infinisil infinisil added the bug label Feb 1, 2024
@infinisil infinisil mentioned this issue Feb 1, 2024
Draft
3 tasks
@infinisil infinisil added the regression Something doesn't work anymore label Feb 1, 2024
@thufschmitt thufschmitt moved this to To triage in Nix team Feb 2, 2024
@infinisil infinisil mentioned this issue Feb 3, 2024
Merged
13 tasks
@roberth roberth self-assigned this Feb 5, 2024
@infinisil
Copy link
Member Author

Bisection leads to 83c067c from #9497 causing this regression

@infinisil infinisil mentioned this issue Feb 7, 2024
Merged
@alois31 alois31 mentioned this issue Feb 10, 2024
Merged
@infinisil infinisil mentioned this issue Feb 15, 2024
Draft
9 tasks
@domenkozar
Copy link
Member

@edolstra what are your thoughts on this?

@Ericson2314
Copy link
Member

#9985 fixes this

@github-project-automation github-project-automation bot moved this from To triage to Done in Nix team Feb 16, 2024
@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/tweag-nix-dev-update-54/39990/1

srid added a commit to srid/nixos-config that referenced this issue Mar 26, 2024
@srid
Don't use unstable nix CLI
380b12e 
Because it broke colmena,
zhaofengli/colmena#190

Ref:
- NixOS/nix#9497
- NixOS/nix#9901
- NixOS/nix#9985
huang12zheng pushed a commit to huang12zheng/nixos-config that referenced this issue Dec 5, 2024
@srid
Don't use unstable nix CLI
de240f6 
Because it broke colmena,
zhaofengli/colmena#190

Ref:
- NixOS/nix#9497
- NixOS/nix#9901
- NixOS/nix#9985
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roberth roberth

Labels
bug regression Something doesn't work anymore
Projects
Nix team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore builtins.pathExists behavior on broken symlinks alois31/nix
5 participants
@domenkozar @roberth @Ericson2314 @infinisil @nixos-discourse