~Add nixos-unstable based outputs, bdwgc 8.2.4~, Nixpkgs lib tests, cleanup #9900
Conversation
|
Tracked down the regression: #9901 |
github-actions
bot
added
the
with-tests
roberth
force-pushed
the
nixpkgs-lib-tests
branch
from
0151ab3 to
f757dba
Compare
|
|
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
roberth
force-pushed
the
nixpkgs-lib-tests
branch
from
bcc13a8 to
7346a04
Compare
roberth
changed the title
roberth
force-pushed
the
nixpkgs-lib-tests
branch
from
d67adcf to
1fdd1c6
Compare
|
Marking as draft again while waiting for which unfortunately wasn't completed yet, and I've duplicated some part of that work independently :( |
|
Discussed during the Nix maintainers meeting on 2024-02-28.
|
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-02-28-nix-team-meeting-129/40499/1 |
|
Discussed during the Nix maintainers meeting on 2024-03-04.
|
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-03-04-nix-team-meeting-minute-130/40830/1 |
Flake lock file updates:
• Added input 'nixpkgs-nixos-unstable':
'github:NixOS/nixpkgs/b8697e57f10292a6165a20f03d2f42920dfaf973' (2024-03-03)
Since they're generated by autoreconfPhase, we don't need to commit them (and update them whenever they change upstream). We didn't provide configure anyway, so having to run something like autoreconfPhase is already expected by users.
Manually tested by printing to stderr in both branches (sp in os
stack, or not), and triggering a GC in a filterSource function,
e.g.:
let
generateTree = n: if n == 0 then "ha" else { left = generateTree (n - 1); right = generateTree (n - 1); };
in
builtins.deepSeq (generateTree 18) ...
Note that the darwin still uses the strategy of disabling GC, despite
having an implementation that compiles. The proper solution will be
enabled and tested later.
This re-enables support for older bwdgc versions without complicating the code too much. Coroutines generally only interfere with GC during source filtering, so it's not too bad of a regression on older bdwgc. This seems preferable over conditional compilation to enable the patch etc; we've already spent a lot of complexity budget on this GC-coroutine interaction...
roberth
force-pushed
the
nixpkgs-lib-tests
branch
from
81fc556 to
e198417
Compare
roberth
changed the title
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-03-06-nix-team-meeting-131/42959/1 |
roberth
changed the title
Warning
Most of this got reused in #10835, except for the multi-nixpkgs flake, which I'm not sure whether that's the right solution.
Motivation
Nixpkgs currently has a failing test in
This might be a regression.
This PR
The goal of this PR is to update the Nixpkgs pin so that we can run the latest tests again, including @infinisil's extensive
filesetstests that found the change in behavior.TODO
Follow-up?
pkgs/test/release/default.nix?Context
Uses lib/tests/test-with-nix.nix: init entrypoint for NixOS/nix CI nixpkgs#290831
Regressions that would have been caught if we updated Nixpkgs earlier
builtins.pathExistsreturns false on symlinks that point to non-existent paths #9901Closes Test Nix using
nixos-unstableon the CI #10156Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.