-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test perl bindings with nix-serve
#11531
base: master
Are you sure you want to change the base?
Conversation
This includes NixOS/nixpkgs#342817 Flake lock file updates: • Updated input 'nixpkgs': 'github:NixOS/nixpkgs/c3d4ac725177c030b1e289015989da2ad9d56af0' (2024-08-15) → 'github:NixOS/nixpkgs/3a458f7c763ca62c6bf454b8d828bd86b7250671' (2024-09-18)
6275529
to
97bd6eb
Compare
There is a tiny test suite for the perl bindings, but it is indeed not useful for seeing if certain apps have upgraded. In this case the breaking change in the Perl bindings was intentional, so a mere test suite would not have caught it. |
passthru = lib.optionalAttrs (stdenv.buildPlatform.canExecute stdenv.hostPlatform) { | ||
perl-bindings = nix-perl-bindings; | ||
}; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would rather not do that here (it doesn't work with the split packages so well), and instead just slap on the attribute for the nix-serve
override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on the concept
I'm 👎 on this, since
takes the |
In other projects, I've added overrides conditioned on e.g.
👍 let's make sure to fix that. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-09-18-nix-team-meeting-minutes-179/52361/1 |
I worked on improving testing in nix-serve here: edolstra/nix-serve#61 |
Motivation
Avoid being caught by surprise when updating
nix
in Nixpkgs.Alternatives:
Context
See context of Support Nix::Store from 2.21 onwards edolstra/nix-serve#60
Blocked on experimental feature flag as in nix-serve: unstable-2018-03-20 → unstable-2024-09-17 nixpkgs#342714
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.