fix env-vars beeing written to /tmp
#11713
Merged
+14
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
force-pushed
the
env-vars
branch
2 times, most recently
from
09929cf
to
9dc73a7
Compare
edolstra
reviewed
Oct 21, 2024
Mic92
added
the
backport 2.24-maintenance
github-actions
bot
added
the
store
Mic92
force-pushed
the
env-vars
branch
2 times, most recently
from
6316c5a
to
5d83991
Compare
This overall seems like insecure tmp file handling to me. Because other users could replace files in /tmp with a symlink and make the nix-shell override other files. fixes NixOS#11470
github-actions
bot
added
the
with-tests
|
Added a test. |
edolstra
added a commit
that referenced
this pull request
Oct 22, 2024
…1713 fix env-vars beeing written to `/tmp` (backport #11713)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current status: works on my machine
This overall seems like insecure tmp file handling to me. Because other users could replace files in /tmp with a symlink and make the nix-shell override other files.
fixes #11470