Set minimum Windows API to Windows 8 #11796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anything less won't compile because we're using GetCurrentThreadStackLimits from Windows 8.
|
I know that a goal of Windows 10 probably makes more sense, since everything else is EOL, but we're actually not using any recent API (yet) |
edolstra
approved these changes
Nov 4, 2024
| @@ -91,6 +91,7 @@ ifdef HOST_WINDOWS | |||
| # | |||
| # TODO do not do this, and instead do fine-grained export annotations. | |||
| GLOBAL_LDFLAGS += -Wl,--export-all-symbols | |||
| GLOBAL_CXXFLAGS += -D_WIN32_WINNT=0x0602 | |||
There was a problem hiding this comment.
Maybe add a comment here which Windows version this denotes.
|
Also don't forget the Meson build! The windows one will be gone shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anything less won't compile because we're using GetCurrentThreadStackLimits from Windows 8.
Motivation
Discovered when trying to compile under mingw64, which seems to set a value of 0x0601 (Windows 7)
Context
https://learn.microsoft.com/en-us/cpp/porting/modifying-winver-and-win32-winnt?view=msvc-170