Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EvalState::resolveLookupPathPath(): Call resolveSymlinks() before pathExists() #12347

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

edolstra
Copy link
Member

@edolstra edolstra commented Jan 24, 2025

Motivation

Fixes #12339. This was broken in af07f33.

Context


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@edolstra edolstra added the backport 2.26-maintenance Automatically creates a PR against the branch label Jan 24, 2025
@github-actions github-actions bot added the with-tests Issues related to testing. PRs with tests have some priority label Jan 24, 2025
@edolstra edolstra added the regression Something doesn't work anymore label Jan 24, 2025
Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Classic. We should change the interface so that low level methods like pathExists() aren't the default pick.
Ok fix though.

@roberth roberth merged commit c527fe0 into NixOS:master Jan 24, 2025
13 checks passed
@edolstra edolstra deleted the fix-12339 branch January 24, 2025 14:02
mergify bot added a commit that referenced this pull request Jan 24, 2025
…2347

EvalState::resolveLookupPathPath(): Call resolveSymlinks() before pathExists() (backport #12347)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.26-maintenance Automatically creates a PR against the branch regression Something doesn't work anymore with-tests Issues related to testing. PRs with tests have some priority
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Most nix commands not working on a fresh MacOS 15.2 install
2 participants