Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "illegal path references in fixed output derivation" error #12356

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

Artturin
Copy link
Member

The main improvement is that the new message gives an example of a path that is referenced, which should make it easier to track down. While there, I also clarified the wording, saying exactly why the paths in question were illegal.

By @bmillwood in #11673

Motivation

Context


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

The main improvement is that the new message gives an example of a path
that is referenced, which should make it easier to track down. While
there, I also clarified the wording, saying exactly why the paths in
question were illegal.
@Artturin Artturin requested a review from Ericson2314 as a code owner January 25, 2025 18:12
@Artturin Artturin added backport 2.23-maintenance Automatically creates a PR against the branch backport 2.24-maintenance Automatically creates a PR against the branch backport 2.25-maintenance Automatically creates a PR against the branch backport 2.26-maintenance Automatically creates a PR against the branch labels Jan 25, 2025
@bmillwood
Copy link
Contributor

thanks for PR-ing this, sorry I never got around to it myself :)

@Artturin Artturin removed the backport 2.23-maintenance Automatically creates a PR against the branch label Jan 25, 2025
@Ericson2314 Ericson2314 merged commit 06de255 into NixOS:master Jan 26, 2025
12 checks passed
mergify bot added a commit that referenced this pull request Jan 26, 2025
…2356

Improve "illegal path references in fixed output derivation" error (backport #12356)
mergify bot added a commit that referenced this pull request Jan 26, 2025
…2356

Improve "illegal path references in fixed output derivation" error (backport #12356)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.24-maintenance Automatically creates a PR against the branch backport 2.25-maintenance Automatically creates a PR against the branch backport 2.26-maintenance Automatically creates a PR against the branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants