-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decode string context straight to using StorePaths #6237
Decode string context straight to using StorePaths #6237
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last commit looks good to me. Apart from the potential conflicts, is there any reason for this to depend on #6236 ?
@thufschmitt It is probably not necessary, but I was a bit nervous about making a |
59fa30e
to
d60a76d
Compare
I gather decoding happens on demand, so I hope don't think this should have any perf implications one way or the other.
d60a76d
to
4d6a380
Compare
Squashed out the second commit so there is is no |
🎉 All dependencies have been resolved ! |
@edolstra how is this? The core change is the switch to The auxillary change is new names for strong contexts, but I think this is good:
|
Thanks! |
Thank you! |
I gather decoding happens on demand, so I hope don't think this should
have any perf implications one way or the other.