Add builtins.fetchClosure #6302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows closures to be imported at evaluation time, without
requiring the user to configure substituters. E.g.
builtins.fetchClosure {
storePath = /nix/store/f89g6yi63m1ywfxj96whv5sxsm74w5ka-python3.9-sqlparse-0.4.2;
from = "https://cache.ngi0.nixos.org";
}
The advantage is that the resulting closure doesn't need to be signed, so you don't need to configure any binary cache keys on the client.
LocalStore::addToStore() since 79ae9e4 expects a regular NAR hash, rather than a NAR hash modulo self-references. Fixes NixOS#6300. Also, makeContentAddressed() now rewrites the entire closure (so 'nix store make-content-addressable' no longer needs '-r'). See NixOS#6301.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-27/18433/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function allows fetching a previously built closure from a binary cache at evaluation time. For instance:
fetches
/nix/store/r2jd...from the specified binary cache, and rewrites it into the content-addressed store path/nix/store/ldbh.... This is similar tobuiltins.storePathin that it allows you to use a previously built store path in a Nix expression. However, it is more reproducible because it requires specifying a binary cache from which the path can be fetched (so it's a better alternative to #5868). Also, requiring a content-addressed final store path avoids the need for users to configure binary cache public keys.This PR also renames
nix store make-content-addressabletonix store make-content-addressed, fixes #6300, and allows it to rewrite a closure from another store in one operation.