flake: update nixpkgs: 22.11 -> 23.05 #8569

vcunat · 2023-06-22T09:23:08Z

Motivation

Pinned nixpkgs commit over half a year old.

Context

#1254 (comment)

Checklist for maintainers

Maintainers: tick if completed or explain if not relevant

agreed on idea
agreed on implementation strategy
tests, as appropriate
- functional tests - tests/**.sh
- unit tests - src/*/tests
- integration tests - tests/nixos/*
documentation in the manual
documentation in the internal API docs
code and comments are self-explanatory
commit message explains why the change was made
new feature or incompatible change: updated release notes

Priorities

Add 👍 to pull requests you find important.

vcunat · 2023-06-22T09:44:53Z

nix flake check

nixpkgs-lib-tests: nix changed error message which breaks a too sensitive test

vcunat · 2023-06-23T08:33:57Z

After the nixpkgs fix, nix build and nix flake check passed for me on x86_64 NixOS.

Ericson2314 · 2023-06-27T11:44:55Z

What's the status on this? Is the stuff we need in Nixpkgs already?

nixos-discourse · 2023-06-27T11:45:34Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/is-nixbsd-a-posibility/29612/17

domenkozar · 2023-06-27T11:52:11Z

Once CI passes, we should just merge. There's nothing blocking it.

domenkozar · 2023-06-27T12:14:36Z

I'm not sure why macos is failing on: lib-path-tests> error: getting status of '/nix/store/.links': Operation not permitted

vcunat · 2023-06-27T12:40:30Z

Yes, it's in there and I had updated the lockfile and the commands above passed for me. I thought CI also passed but I'm not sure.

domenkozar · 2023-06-27T13:14:49Z

It seems that linux passes, but macos fails. I don't see the history, but did the same error happen before on linux?

vcunat · 2023-06-27T13:17:45Z

All tests including this one seem to pass on nix master, but I have no idea why this PR could make a difference here.

domenkozar · 2023-06-27T16:37:35Z

I can't reproduce it on aarch64-darwin and I don't have access to an intel machine.

Maybe you can pass -L to nix invocation so that we get the full log?

vcunat · 2023-06-27T16:51:18Z

I have access to a native x86_64-darwin, if you tell me what to run/inspect.

domenkozar · 2023-06-27T16:54:08Z

nix flake check should reproduce it.

vcunat · 2023-06-27T17:40:49Z

Uh, I don't know :-/

$ nix flake check -L
trace: warning: Module argument `nodes.client.config` is deprecated. Use `nodes.client` instead.
trace: warning: The option `services.openssh.permitRootLogin' defined in `/nix/store/gmgk5lx7bsckhwpsba1mni4qnrqhpykk-source/tests/nixos/nix-copy.nix' has been renamed to `services.openssh.settings.PermitRootLogin'.
trace: warning: Module argument `nodes.http_dns.config` is deprecated. Use `nodes.http_dns` instead.
trace: warning: Module argument `nodes.github.config` is deprecated. Use `nodes.github` instead.
trace: warning: Module argument `nodes.sourcehut.config` is deprecated. Use `nodes.sourcehut` instead.
checking Hydra job 'hydraJobs.tests.setuid.i686-linux'Segmentation fault: 11

(repeatedly)

vcunat · 2023-06-27T19:14:00Z

I tried to run the same with newer nix than was on that machine and it all passed.

roberth · 2023-06-29T10:25:29Z

I'm not sure why macos is failing on: lib-path-tests> error: getting status of '/nix/store/.links': Operation not permitted

Judging from lib-path-tests> this is from nix running inside the sandbox.
lib/tests/release.nix does configure a different store location, but lib/path/tests/default.nix does not.

Probably the hard link optimization wasn't triggered in an older version of nix. As that runs async, it could be quite non-deterministic.

It would be great to have a slightly more functional default nix store when nix runs in the sandbox. We'll need that for effective use of RFC 92 dynamic derivations anyway. For a test like this, we run nix just for instantiation, which is basically the same requirement that we have for 92, and we've established that a very restrictive recursive nix socket that basically only allows addToStore is unlikely to cause a structural problem.

vcunat · 2023-06-29T10:44:04Z

I haven't mentioned that the machine I tried is configured close to defaults, i.e. without sandboxing.

edolstra · 2023-06-30T12:15:58Z

I set up a jobset for this PR: https://hydra.nixos.org/eval/1797165

nixpkgsLibTests works fine on macOS on Hydra, so this seems to be a GHA-specific issue. I would suggest removing nixpkgsLibTests from checks (so it will still run on Hydra). Or maybe only running it on x86_64-linux on GHA.

There are two other problems:

The coverage job crashes with corrupted size vs. prev_size in fastbins: https://hydra.nixos.org/build/226125785
tests.containers fails with Failed to mount proc (type proc) on /proc (MS_NOSUID|MS_NODEV|MS_NOEXEC ""): Operation not permitted: https://hydra.nixos.org/build/226125763

edolstra · 2023-07-03T10:23:47Z

The crashing make check in the coverage job is caused by some interaction between gcov and rapidcheck. Disabling the rapidcheck tests makes the coverage job succeed.

So we may need to decide whether we care more about coverage analysis or property testing...

roberth · 2023-07-03T15:16:31Z

Yikes.

These lines in the log seem the describe the cause:

[----------] 2 tests from StorePathTest_RapidCheck
[ RUN      ] StorePathTest_RapidCheck.prop_regex_accept
corrupted size vs. prev_size in fastbins
[       OK ] StorePathTest_RapidCheck.prop_regex_accept (8 ms)
[ RUN      ] StorePathTest_RapidCheck.prop_round_rip
[       OK ] StorePathTest_RapidCheck.prop_round_rip (8 ms)
[----------] 2 tests from StorePathTest_RapidCheck (17 ms total)

corrupted size vs. prev_size in fastbins seems indicative of a memory corruption. I'll try valgrind.

Ericson2314 · 2023-08-25T00:48:58Z

We have Hydra results! https://hydra.nixos.org/eval/1798739?compare=1798723&full=0#tabs-now-fail

aarch64-darwin is newly broken because AWS SDK failed to build
aarch64-linux is fixed
coverage is newly broken
tests.containers is newly broken

Interface has changed upstream. It *should* be fine to test 23.05's other Nix versions as those *should* succeed, but that's not the case and it's obfuscating our terrible CI setup's log.

The lowdown input can't be updated; `nix build` would fail to find it. Co-authored-by: Robert Hensing <[email protected]>

roberth · 2023-09-01T13:14:19Z

Meeting notes 2023-09-01

Need to fix master by either fixing+merging the NixOS 23.05 update or reverting the PR that broke aarch64-linux
- @edolstra will look into issue in auto uid experimental feature + the coverage issue
"vanila" (without our overrides) AWS SDK is buildable on release-23.05 with tests.
- let's try building again with the tests, hopefully the AWS tests pass this time.

nixos-discourse · 2023-09-01T13:20:47Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-09-01-nix-team-meeting-minutes-84/32466/1

edolstra · 2023-09-01T14:13:28Z

@roberth I updated this PR to use the latest 23.05, but it's still failing in the aws-sdk-cpp build: https://hydra.nixos.org/build/233688522

Ericson2314 · 2023-09-02T18:58:26Z

https://hydra.nixos.org/build/233688522 and https://hydra.nixos.org/build/232704350 look like the same derivation? I think we need to manually restart the failing builds in Hydra, since the 23.05 bump did not include a mass rebuild.

vcunat · 2023-09-02T19:43:47Z

That failing build has been retried several times already; you can see some attempts e.g. on https://hydra.nixos.org/build/232704299#tabs-buildsteps

(You point to two different builds of nix but both depend on the same aws-sdk-cpp.)

roberth · 2023-09-03T17:32:35Z

I'm having network difficulties with my aarch64-darwin node, so I can't troubleshoot that build right now.

https://hydra.nixos.org/build/233688539

This is broken because of a change in systemd in NixOS 23.05. It fails with Failed to mount proc (type proc) on /proc (MS_NOSUID|MS_NODEV|MS_NOEXEC ""): Operation not permitted

edolstra · 2023-09-19T15:06:27Z

I've disabled the systemd-nspawn test. That looks like a regression/change in systemd in NixOS 23.05 and I have no idea how to fix it.

Ericson2314 · 2023-09-19T15:08:52Z

Thanks @edolstra for taking a look at this.

https://hydra.nixos.org/build/235888160 This is needed because Nixpkgs now contains dangling symlinks (pkgs/test/nixpkgs-check-by-name/tests/symlink-invalid/pkgs/by-name/fo/foo/foo.nix).

cole-h · 2023-09-19T18:26:38Z

flake.nix

+  #inputs.nixpkgs.url = "github:NixOS/nixpkgs/nixos-23.05-small";
+  inputs.nixpkgs.url = "github:edolstra/nixpkgs/fix-aws-sdk-cpp";


https://nixpk.gs/pr-tracker.html?pr=256102 once this hits small, we can go back.

edolstra · 2023-09-20T09:30:48Z

Merging this since the jobset is now green: https://hydra.nixos.org/eval/1799383

cole-h · 2023-09-20T16:15:47Z

tests/nixos/containers/containers.nix

@@ -56,8 +56,8 @@
    host.fail("nix build -v --auto-allocate-uids --no-sandbox -L --offline --impure --file ${./id-test.nix} --argstr name id-test-6 --arg uidRange true")

    # Run systemd-nspawn in a Nix build.
-    host.succeed("nix build -v --auto-allocate-uids --sandbox -L --offline --impure --file ${./systemd-nspawn.nix} --argstr nixpkgs ${nixpkgs}")
-    host.succeed("[[ $(cat ./result/msg) = 'Hello World' ]]")
+    #host.succeed("nix build -v --auto-allocate-uids --sandbox -L --offline --impure --file ${./systemd-nspawn.nix} --argstr nixpkgs ${nixpkgs}")


I attempted to re-enable this test in #9008.

These statements are taken from the `lib/test/release.nix` tests, which previously also worked on darwin. Unblocks NixOS/nix#8569 when backported

vcunat changed the title ~~flake: update inputs, nixpkgs: 22.11 -> 23.05~~ flake: update nixpkgs: 22.11 -> 23.05 Jun 22, 2023

vcunat mentioned this pull request Jun 22, 2023

Init nixVersions.minimum and fix lib tests for all Nix versions NixOS/nixpkgs#234070

Merged

1 task

vcunat force-pushed the p/flake-update branch from 23e51bd to 95ecb97 Compare June 23, 2023 08:12

vcunat marked this pull request as ready for review June 23, 2023 08:12

vcunat requested a review from edolstra as a code owner June 23, 2023 08:12

roberth mentioned this pull request Jun 26, 2023

lib/path/tests: Add --show-trace NixOS/nixpkgs#239902

Merged

12 tasks

roberth mentioned this pull request Jun 27, 2023

build with nixos-unstable channel #8590

Draft

Ericson2314 mentioned this pull request Jun 29, 2023

Add NetBSD/FreeBSD Support #3280

Closed

roberth mentioned this pull request Jun 29, 2023

A very restricted recursive nix socket in the sandbox #8602

Open

edolstra requested a review from thufschmitt as a code owner July 3, 2023 10:21

github-actions bot added the tests label Jul 3, 2023

Ericson2314 force-pushed the p/flake-update branch from 4ca5cee to f5f1637 Compare August 22, 2023 23:02

roberth added 2 commits August 30, 2023 19:34

nixpkgsLibTests: Only test our Nix

3384f70

Interface has changed upstream. It *should* be fine to test 23.05's other Nix versions as those *should* succeed, but that's not the case and it's obfuscating our terrible CI setup's log.

Fix nix-copy test

be3362e

Ericson2314 force-pushed the p/flake-update branch from f5f1637 to d3588a6 Compare August 30, 2023 23:35

Ericson2314 mentioned this pull request Aug 31, 2023

Support cross compiling to BSD and CI it #8887

Merged

8 tasks

edolstra added this to the nix-2.18 milestone Sep 1, 2023

flake: update nixpkgs: 22.11 -> 23.05

539cc5e

The lowdown input can't be updated; `nix build` would fail to find it. Co-authored-by: Robert Hensing <[email protected]>

edolstra force-pushed the p/flake-update branch from d3588a6 to 539cc5e Compare September 1, 2023 12:07

edolstra added 4 commits September 19, 2023 13:33

Merge remote-tracking branch 'origin/master' into p/flake-update

c451b48

Try aws-sdk-cpp fix

c8afa01

Disable rapidcheck tests in the coverage run

126e264

https://hydra.nixos.org/build/233688539

Disable systemd-nspawn test

c6953d1

This is broken because of a change in systemd in NixOS 23.05. It fails with Failed to mount proc (type proc) on /proc (MS_NOSUID|MS_NODEV|MS_NOEXEC ""): Operation not permitted

Use "touch -h"

b6b2a0a

https://hydra.nixos.org/build/235888160 This is needed because Nixpkgs now contains dangling symlinks (pkgs/test/nixpkgs-check-by-name/tests/symlink-invalid/pkgs/by-name/fo/foo/foo.nix).

edolstra marked this pull request as ready for review September 19, 2023 15:59

cole-h reviewed Sep 19, 2023

View reviewed changes

edolstra merged commit 6ce358b into NixOS:master Sep 20, 2023
8 checks passed

vcunat deleted the p/flake-update branch September 20, 2023 09:34

cole-h reviewed Sep 20, 2023

View reviewed changes

Gerg-L mentioned this pull request Sep 22, 2023

flake: complete update to 23.05 #9026

Merged

PkmX pushed a commit to PkmX/nixpkgs.lib that referenced this pull request Aug 23, 2024

lib/path/tests: Fix test setup on darwin

6c3c783

These statements are taken from the `lib/test/release.nix` tests, which previously also worked on darwin. Unblocks NixOS/nix#8569 when backported

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

flake: update nixpkgs: 22.11 -> 23.05 #8569

flake: update nixpkgs: 22.11 -> 23.05 #8569

vcunat commented Jun 22, 2023

vcunat commented Jun 22, 2023 •

edited

Loading

vcunat commented Jun 23, 2023

Ericson2314 commented Jun 27, 2023

nixos-discourse commented Jun 27, 2023

domenkozar commented Jun 27, 2023

domenkozar commented Jun 27, 2023

vcunat commented Jun 27, 2023

domenkozar commented Jun 27, 2023

vcunat commented Jun 27, 2023 •

edited

Loading

domenkozar commented Jun 27, 2023

vcunat commented Jun 27, 2023 •

edited

Loading

domenkozar commented Jun 27, 2023

vcunat commented Jun 27, 2023

vcunat commented Jun 27, 2023

roberth commented Jun 29, 2023

vcunat commented Jun 29, 2023

edolstra commented Jun 30, 2023 •

edited

Loading

edolstra commented Jul 3, 2023

roberth commented Jul 3, 2023

Ericson2314 commented Aug 25, 2023

roberth commented Sep 1, 2023

nixos-discourse commented Sep 1, 2023

edolstra commented Sep 1, 2023

Ericson2314 commented Sep 2, 2023 •

edited

Loading

vcunat commented Sep 2, 2023

roberth commented Sep 3, 2023

edolstra commented Sep 19, 2023

Ericson2314 commented Sep 19, 2023

cole-h Sep 19, 2023

edolstra commented Sep 20, 2023

cole-h Sep 20, 2023

		#inputs.nixpkgs.url = "github:NixOS/nixpkgs/nixos-23.05-small";
		inputs.nixpkgs.url = "github:edolstra/nixpkgs/fix-aws-sdk-cpp";

flake: update nixpkgs: 22.11 -> 23.05 #8569

flake: update nixpkgs: 22.11 -> 23.05 #8569

Conversation

vcunat commented Jun 22, 2023

Motivation

Context

Checklist for maintainers

Priorities

vcunat commented Jun 22, 2023 • edited Loading

vcunat commented Jun 23, 2023

Ericson2314 commented Jun 27, 2023

nixos-discourse commented Jun 27, 2023

domenkozar commented Jun 27, 2023

domenkozar commented Jun 27, 2023

vcunat commented Jun 27, 2023

domenkozar commented Jun 27, 2023

vcunat commented Jun 27, 2023 • edited Loading

domenkozar commented Jun 27, 2023

vcunat commented Jun 27, 2023 • edited Loading

domenkozar commented Jun 27, 2023

vcunat commented Jun 27, 2023

vcunat commented Jun 27, 2023

roberth commented Jun 29, 2023

vcunat commented Jun 29, 2023

edolstra commented Jun 30, 2023 • edited Loading

edolstra commented Jul 3, 2023

roberth commented Jul 3, 2023

Ericson2314 commented Aug 25, 2023

roberth commented Sep 1, 2023

nixos-discourse commented Sep 1, 2023

edolstra commented Sep 1, 2023

Ericson2314 commented Sep 2, 2023 • edited Loading

vcunat commented Sep 2, 2023

roberth commented Sep 3, 2023

edolstra commented Sep 19, 2023

Ericson2314 commented Sep 19, 2023

cole-h Sep 19, 2023

Choose a reason for hiding this comment

edolstra commented Sep 20, 2023

cole-h Sep 20, 2023

Choose a reason for hiding this comment

vcunat commented Jun 22, 2023 •

edited

Loading

vcunat commented Jun 27, 2023 •

edited

Loading

vcunat commented Jun 27, 2023 •

edited

Loading

edolstra commented Jun 30, 2023 •

edited

Loading

Ericson2314 commented Sep 2, 2023 •

edited

Loading