Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support cross compiling to BSD and CI it #8887

Merged
merged 6 commits into from
Sep 25, 2023
Merged

Support cross compiling to BSD and CI it #8887

merged 6 commits into from
Sep 25, 2023

Commits on Sep 20, 2023

  1. Add FreeBSD and NetBSD cross to Nix's flake

    @Ericson2314
    Ericson2314 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    e44d2a6 View commit details
    Browse the repository at this point in the history

  2. Make dev shells work for cross 

    Need to get tools from right package set. Could build clang tools but I
don't want to wait :D.
    @Ericson2314
    Ericson2314 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    28850ee View commit details
    Browse the repository at this point in the history

  3. Make libsodium an unconditional dependency 

    The configure script will not tolerate it being missing.
    @Ericson2314
    Ericson2314 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    564392b View commit details
    Browse the repository at this point in the history

  4. Do not build docs in cross devShell 

    Coppied from the main build; we really should deduplicate this more.
    @Ericson2314
    Ericson2314 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    0db251e View commit details
    Browse the repository at this point in the history

  5. Rename an identifier of ours called stdout 

    This is a reserved identifier on NetBSD --- it is replaced by a macro on
that platform --- and so we cannot use it.
    @Ericson2314
    Ericson2314 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    7f76d7f View commit details
    Browse the repository at this point in the history

  6. Fix boehmgc-coroutine-sp-fallback.diff for FreeBSD 

    Our FreeBSD headers have `pthread_getattr_np`, but we get a link-time
error that is missing. The good news is that there is another similar
function which does exist, and the upstream project elsewhere does just
the [fallback code] we need.

As the fallback code indicates, the two functions are not identical
however as the other one needs explicit initialization. NetBSD supports
both in fact, and its [manpage] is therefore a good
resource on what the differences are.

[fallback code]: https://github.com/ivmai/bdwgc/blob/07a6d0ee8889bca5eaeadc13cabadc363725d216/os_dep.c#L1266-L1272

[manpage]: https://man.netbsd.org/pthread_attr_get_np.3
    @Ericson2314
    Ericson2314 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    c189116 View commit details
    Browse the repository at this point in the history