Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git hashing for Git fetching #9025

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Git hashing for Git fetching #9025

wants to merge 2 commits into from

Commits on Mar 27, 2024

  1. Experimentally return treeHash on git and github fetchers

    @Ericson2314
    Ericson2314 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    ce9ea7e View commit details
    Browse the repository at this point in the history

  2. Git hashing for Git Fetching 

    The git fetcher is now more tree-hash-oriented, and we will want to
integrate this with git fetching eventually. This PR exposes `treeHash`
inputs and outputs in a few ways for this purpose.

Eventually, we should add something like `builtins.derivation`'s
`outputHashMode` to `builtins.fetchTree`, in order to specify we should
use git hashing, and then this and the store-layer git hashing should
meet together, ensuring we have the same tree hash end-to-end.

Part of RFC 133

Co-Authored-By: Matthew Bauer <[email protected]>
Co-Authored-By: Carlo Nucera <[email protected]>
Co-authored-by: Robert Hensing <[email protected]>
    @Ericson2314 @matthewbauer
    @meditans @roberth
    4 people committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    a8314ff View commit details
    Browse the repository at this point in the history