[2.3-maintenance] Escape ${ in strings when printing Nix expressions
#9260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the result of the printing can't be parsed back correctly by
Nix (because the unescaped `${` will be parsed as the begining of an
anti-quotation).
Fix NixOS#3989
(cherry picked from commit 250f8a4)
flokli
changed the title
${ in strings when printing Nix expressions${ in strings when printing Nix expressions
roberth
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #4012 to
2.3-maintenance.Otherwise the result of the printing can't be parsed back correctly by Nix (because the unescaped
${will be parsed as the begining of an anti-quotation).Fix #3989
(cherry picked from commit 250f8a4)
Motivation / Context
TVL is currently using a set of patches backported to 2.3. WIth the recent activity in
2.3-maintenance, we'd like to upstream these patches.Priorities
Add 👍 to pull requests you find important.