tests: fix unused importPath in unfreeNixpkgs function #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* originally importPath in the unfreeNixpkgs function was not used at all. this commit fixes the issue, allowing the function to work as intended.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The nixpkgs used to test profiles was (likely mistakenly) hardcoded to
nixos-unstable-small, and as a result both nixpkgs{Unstable,Stable} used the same nixpkgs version. This causes unexpected assertion failures with(lib.versionAtLeast (lib.versions.majorMinor lib.version) "24.11")This PR unhardcodes the value and resolves the potential issue.
Note that this fails 3 tests at the time of writing, namely
x86_64-linux.nixos-stable-lenovo-legion-16ach6h{,-hybrid,-nvidia}, all because of a non-existenthardware.displayoption in stable nixpkgs.Things done
nixos-hardwareandimporting it via
<nixos-hardware>or Flake input