Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p14s, t14s: fix linux firmware version check #680

Merged
merged 2 commits into from
Jul 30, 2023

Conversation

dadada
Copy link
Contributor

@dadada dadada commented Jul 29, 2023

Description of changes
Things done
  • Tested the changes in your own NixOS Configuration
  • Tested the changes end-to-end by using your fork of nixos-hardware and
    importing it via <nixos-hardware> or Flake input

@samueldr samueldr linked an issue Jul 29, 2023 that may be closed by this pull request
@samueldr
Copy link
Member

@dadada I haven't really looked at the problem more than in this comment, but would it be okay to just remove the check?

In other words, is the earliest version available since 23.05 was released already passing the check? If so, we probably should drop it, as I don't think supporting EOL'd releases is a goal here.

@dadada
Copy link
Contributor Author

dadada commented Jul 29, 2023

@dadada I haven't really looked at the problem more than in this comment, but would it be okay to just remove the check?

In other words, is the earliest version available since 23.05 was released already passing the check? If so, we probably should drop it, as I don't think supporting EOL'd releases is a goal here.

I suppose removing it is alright. If people use EOL NixOS, they can pin an old version of nixos-hardware.

@Mic92 Mic92 merged commit 96e5a0a into NixOS:master Jul 30, 2023
1 check passed
@dadada dadada deleted the fix-linux-firmware branch July 30, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linux-firmware guard fails probably due to new versioning
3 participants