Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p14s: Add common/{cpu,gpu}/amd to imports #682

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

shymega
Copy link
Contributor

@shymega shymega commented Aug 1, 2023

Description of changes

This is my first upstream contribution (intend to contribute configs for
my NUC, GPD, and ClockworkPi devices). Essentially, this change
resolves #492, by adding the common/{cpu,gpu}/amd Nix fragments to the
imports list for the Thinkpad P14s.

Things done
  • Tested the changes in your own NixOS Configuration
  • Tested the changes end-to-end by using your fork of nixos-hardware and
    importing it via <nixos-hardware> or Flake input

I have not been able to test these changes in my own configuration, but I have run the unit tests, which passed, save for the following tests, listed below:

The following 4 test(s) failed:
./tests/run.py '<nixos-hardware/raspberry-pi/4>'
./tests/run.py '<nixos-hardware/asus/zephyrus/ga402>'
./tests/run.py '<nixos-hardware/asus/zephyrus/ga401>'
./tests/run.py '<nixos-hardware/lenovo/legion/16irx8h>'```

This is my first upstream contribution (intend to contribute configs for
my NUC, GPD, and ClockworkPi uConsole/DevTerm). Essentially, this change
resolves #492, by adding the `common/{cpu,gpu}/amd` Nix fragments to the
`imports` list for the Thinkpad P14s.
@Mic92 Mic92 merged commit af69437 into NixOS:master Aug 2, 2023
1 check passed
@shymega shymega deleted the add-common-cpugpu-thinkpad-p14s branch August 2, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add common/cpu/amd and common/gpu/amd to thinkpad p14s
2 participants