Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Dell XPS 13 9333 #686

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Adding Dell XPS 13 9333 #686

merged 2 commits into from
Aug 4, 2023

Conversation

ttamttam
Copy link
Contributor

@ttamttam ttamttam commented Aug 4, 2023

Adding Dell XPS 13 9333
Things done

Note1: In the default.nix file, I imported
../../../common/pc/ssd because my laptop has currently an SSD, but
I'm not sure if it was the case when I bought it or if I installed it later.

Note2: Not sure about this line (services.fwupd.enable = true;).

  • Tested the changes in your own NixOS Configuration
  • Tested the changes end-to-end by using your fork of nixos-hardware and
    importing it via <nixos-hardware> or Flake input

@bagelwaffle
Copy link
Contributor

bagelwaffle commented Aug 4, 2023

Hi there, I’m not a reviewer but just like to say that the device isn’t found in the FWUPD supported device list. However, there might be a component that is supported. I think running fwupdmgr upgrade will give you a list.

@ttamttam
Copy link
Contributor Author

ttamttam commented Aug 4, 2023

Hi there, I’m not a reviewer but just like to say that the device isn’t found in the FWUPD supported device list. However, there might be a component that is supported. I think running fwupdmgr upgrade will give you a list.

Thanks!

@Mic92 Mic92 merged commit b4f1105 into NixOS:master Aug 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants