Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add home-manager to flake sources #481

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add home-manager to flake sources #481

wants to merge 1 commit into from

Conversation

pinpox
Copy link
Member

@pinpox pinpox commented May 17, 2022

Is there any reason why home-manager is still not in here? I feel like there are a lot of people using it and having it's options listed here could be very helpful

@ncfavier
Copy link
Member

See #323 and nix-community/home-manager#2297

@ncfavier ncfavier closed this May 17, 2022
@ncfavier
Copy link
Member

Didn't see this was a PR, reopening in case we want to add home-manager now, but beware it will only index the NixOS module options in https://github.com/nix-community/home-manager/blob/master/nixos/default.nix

@ncfavier ncfavier reopened this May 17, 2022
@pinpox
Copy link
Member Author

pinpox commented May 17, 2022

Having all options in the search was my original goal, but I guess it should be included anyway?

@ncfavier
Copy link
Member

We're hitting a nix bug because home-manager has no lock file. Opened an issue upstream: NixOS/nix#6541

ncfavier
ncfavier approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@ncfavier ncfavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import of home-manager succeeds now. Should we merge this, @garbas @ysndr ?

@ysndr
Copy link
Member

ysndr commented Sep 7, 2022

Is this the homeManagerOptions or the home-manager nixosOptions (and Packages)?

@ysndr ysndr mentioned this pull request Sep 7, 2022
Open
@ncfavier
Copy link
Member

ncfavier commented Sep 8, 2022

beware it will only index the NixOS module options in https://github.com/nix-community/home-manager/blob/master/nixos/default.nix

@Asqiir
Copy link

Asqiir commented Jun 10, 2024

@pinpox what is this PR waiting for? It seems to be approved.

@pinpox @wegank
Add home-manager to flake sources
01049c6 
Is there any reason why home-manager is still not in here? I feel like there are a lot of people using it and having it's options listed here could be very helpful
@pinpox
Copy link
Member Author

pinpox commented Jun 10, 2024

@pinpox what is this PR waiting for? It seems to be approved.

I don't know, I don't have merging rights

@wegank
Copy link
Member

wegank commented Jun 10, 2024

The CI check failed, my guess is that the home-manager metadata is too large for the CI to process in time.

@wegank wegank added help wanted Extra attention is needed blocked Blocked for Merge labels Jun 10, 2024
@pinpox
Copy link
Member Author

pinpox commented Jun 11, 2024

The CI check failed, my guess is that the home-manager metadata is too large for the CI to process in time.

Hmm is there anything I can do about that? Maybe just re-rul the CI and try againb to see if it was a fluke?

@wegank wegank requested a review from garbas June 11, 2024 09:32
@dasJ dasJ added the flake label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncfavier ncfavier ncfavier approved these changes

@garbas garbas Awaiting requested review from garbas

Assignees
No one assigned
Labels
blocked Blocked for Merge flake help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pinpox @ncfavier @ysndr @Asqiir @wegank @dasJ