Skip to content

Commit

Permalink
pythonPackages.greenlet: 0.4.17 -> 1.0.0
Browse files Browse the repository at this point in the history
Update greenlet to 1.0.0.

meinheld declares a dependency to greenlet <0.5, but according to [1]
and [2], there are no API or ABI changes leading to greenlet-1.0.0, so
it seems reasonable to drop the strict requirement.  This commit
uses substituteInPlace to patch setup.py since no upstream commit has
landed in the main branch yet.

Morehover, quoting [2]:

    Prior to greenlet 1.0 there were no semantic meanings attached to
    greenlet versions — API and ABI regularly changed from 0.4.x
    to 0.4.x+1, so their current pin doesn't make much sense anyway.

nix-review reveals few broken packages that are also broken in master.

[1] mopemope/meinheld#123
[2] benoitc/gunicorn#2541 (comment)
  • Loading branch information
lsix committed Apr 6, 2021
1 parent 448e3c4 commit 14cae0a
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
9 changes: 2 additions & 7 deletions pkgs/development/python-modules/greenlet/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -8,21 +8,16 @@

buildPythonPackage rec {
pname = "greenlet";
version = "0.4.17";
version = "1.0.0";
disabled = isPyPy; # builtin for pypy

src = fetchPypi {
inherit pname version;
sha256 = "0swdhrcq13bdszv3yz5645gi4ijbzmmhxpb6whcfg3d7d5f87n21";
sha256 = "1y6wbg9yhm9dw6m768n4yslp56h85pnxkk3drz6icn15g6f1d7ki";
};

propagatedBuildInputs = [ six ];

# see https://github.com/python-greenlet/greenlet/issues/85
preCheck = ''
rm tests/test_leaks.py
'';

meta = {
homepage = "https://pypi.python.org/pypi/greenlet";
description = "Module for lightweight in-process concurrent programming";
Expand Down
6 changes: 6 additions & 0 deletions pkgs/development/python-modules/meinheld/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,12 @@ buildPythonPackage rec {
sha256 = "008c76937ac2117cc69e032dc69cea9f85fc605de9bac1417f447c41c16a56d6";
};

patchPhase = ''
# Allow greenlet-1.0.0.
# See https://github.com/mopemope/meinheld/pull/123
substituteInPlace setup.py --replace "greenlet>=0.4.5,<0.5" "greenlet>=0.4.5,<2.0.0"
'';

propagatedBuildInputs = [ greenlet ];

# No tests
Expand Down

0 comments on commit 14cae0a

Please sign in to comment.