Skip to content

Commit

Permalink
binary: run meson checks
Browse files Browse the repository at this point in the history
also clean up a few things
  • Loading branch information
getchoo committed Nov 7, 2024
1 parent cf166c4 commit 5a36b0f
Showing 1 changed file with 17 additions and 5 deletions.
22 changes: 17 additions & 5 deletions pkgs/by-name/bi/binary/package.nix
Original file line number Diff line number Diff line change
@@ -1,23 +1,25 @@
{
lib,
fetchFromGitHub,
python3Packages,
stdenv,
appstream,
blueprint-compiler,
desktop-file-utils,
fetchFromGitHub,
glib,
gobject-introspection,
gtk4,
libadwaita,
meson,
ninja,
pkg-config,
python3Packages,
wrapGAppsHook4,
}:

python3Packages.buildPythonApplication rec {
pname = "binary";
version = "5.1";
format = "other";
pyproject = false;

src = fetchFromGitHub {
owner = "fizzyizzy05";
Expand All @@ -26,12 +28,15 @@ python3Packages.buildPythonApplication rec {
hash = "sha256-HBmWaT0cjYz3UAO1r5chFW7KARpL1EnY8wEeR9etPE0=";
};

strictDeps = true;

nativeBuildInputs = [
appstream
blueprint-compiler
desktop-file-utils
glib # need glib-compile-schemas
desktop-file-utils # for `desktop-file-validate`
glib # for `glib-compile-schemas`
gobject-introspection
gtk4 # for `gtk-update-icon-cache`
meson
ninja
pkg-config
Expand All @@ -45,6 +50,13 @@ python3Packages.buildPythonApplication rec {
dontWrapGApps = true;
makeWrapperArgs = [ "\${gappsWrapperArgs[@]}" ];

# NOTE: `postCheck` is intentionally not used here, as the entire checkPhase
# is skipped by `buildPythonApplication`
# https://github.com/NixOS/nixpkgs/blob/9d4343b7b27a3e6f08fc22ead568233ff24bbbde/pkgs/development/interpreters/python/mk-python-derivation.nix#L296
postInstallCheck = ''
mesonCheckPhase
'';

meta = {
description = "Small and simple app to convert numbers to a different base";
homepage = "https://github.com/fizzyizzy05/binary";
Expand Down

0 comments on commit 5a36b0f

Please sign in to comment.