Skip to content

Commit

Permalink
cartridges: run meson checks
Browse files Browse the repository at this point in the history
also clean up a few things
  • Loading branch information
getchoo committed Nov 7, 2024
1 parent 57f23ed commit a01b23f
Showing 1 changed file with 20 additions and 6 deletions.
26 changes: 20 additions & 6 deletions pkgs/by-name/ca/cartridges/package.nix
Original file line number Diff line number Diff line change
@@ -1,18 +1,21 @@
{
lib,
fetchFromGitHub,
python3Packages,
appstream,
blueprint-compiler,
desktop-file-utils,
gobject-introspection,
fetchFromGitHub,
glib,
glib-networking,
gobject-introspection,
gtk4,
libadwaita,
meson,
ninja,
pkg-config,
python3Packages,
wrapGAppsHook4,
}:

python3Packages.buildPythonApplication rec {
pname = "cartridges";
version = "2.10.1";
Expand All @@ -25,10 +28,14 @@ python3Packages.buildPythonApplication rec {
hash = "sha256-uwU0jW5+33hiqpuG83r0GVfANl6ltDLa3s4s0IJHRoQ=";
};

strictDeps = true;

nativeBuildInputs = [
appstream
blueprint-compiler
desktop-file-utils
desktop-file-utils # for `desktop-file-validate`
glib # for `glib-compile-schemas`
gtk4 # for `gtk-update-icon-cache`
gobject-introspection
meson
ninja
Expand All @@ -49,12 +56,19 @@ python3Packages.buildPythonApplication rec {
];

dontWrapGApps = true;
makeWrapperArgs = [ ''''${gappsWrapperArgs[@]}'' ];
makeWrapperArgs = [ "\${gappsWrapperArgs[@]}" ];

postFixup = ''
wrapPythonProgramsIn $out/libexec $out $pythonPath
'';

# NOTE: `postCheck` is intentionally not used here, as the entire checkPhase
# is skipped by `buildPythonApplication`
# https://github.com/NixOS/nixpkgs/blob/9d4343b7b27a3e6f08fc22ead568233ff24bbbde/pkgs/development/interpreters/python/mk-python-derivation.nix#L296
postInstallCheck = ''
mesonCheckPhase
'';

meta = {
description = "GTK4 + Libadwaita game launcher";
longDescription = ''
Expand All @@ -64,7 +78,7 @@ python3Packages.buildPythonApplication rec {
You can sort and hide games or download cover art from SteamGridDB.
'';
homepage = "https://apps.gnome.org/Cartridges/";
changelog = "https://github.com/kra-mo/cartridges/releases/tag/${lib.removePrefix "refs/tags/" src.rev}";
changelog = "https://github.com/kra-mo/cartridges/releases/tag/${version}";
license = lib.licenses.gpl3Plus;
maintainers = with lib.maintainers; [ getchoo ];
mainProgram = "cartridges";
Expand Down

0 comments on commit a01b23f

Please sign in to comment.