Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscodium: 1.59.0 -> 1.59.1 #134915

Merged

Conversation

samuela
Copy link
Member

@samuela samuela commented Aug 20, 2021

Motivation for this change

Upgrades vscodium from 1.59.1 to 1.59.1

This PR was automatically generated by nixpkgs-upkeep.

  • CI workflow that created this PR.
  • Internal tag: 07c2580bbaa057c4bdd81a81d3e0ff25.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mohe2015
Copy link
Contributor

@samuela wrong from version in commit message and title

@samuela
Copy link
Member Author

samuela commented Aug 20, 2021

Oops! I'll fix!

@happysalada
Copy link
Contributor

Result of nixpkgs-review pr 134915 run on x86_64-darwin 1

1 package built:
  • vscodium

@happysalada
Copy link
Contributor

Here are the issues that are fixed
https://github.com/microsoft/vscode/issues?q=is%3Aissue+milestone%3A%22July+2021+Recovery%22+is%3Aclosed
looks like a small bug release, I'm fine to merge this when you have a moment to fix the commit message.

@SuperSandro2000 SuperSandro2000 changed the title vscodium: 1.59.1 -> 1.59.1 vscodium: 1.59.0 -> 1.59.1 Aug 20, 2021
@SuperSandro2000 SuperSandro2000 merged commit aab7fa7 into NixOS:master Aug 20, 2021
@samuela samuela deleted the upkeep-bot/vscodium-1.59.1-1629420323 branch August 20, 2021 20:25
@github-actions
Copy link
Contributor

Successfully created backport PR #135409 for release-21.05.

@drupol
Copy link
Contributor

drupol commented Sep 8, 2021

@samuela 1.60.0 has been released!

@samuela
Copy link
Member Author

samuela commented Sep 8, 2021

The auto updater should pick it up now that it's released.

@drupol
Copy link
Contributor

drupol commented Sep 8, 2021

But it has been released 2 days ago already :) and VSCode, 6 days ago (but VSCode is ok)

@samuela
Copy link
Member Author

samuela commented Sep 8, 2021

The vscodium project releases usually lag behind the vscode ones by a few days. You can check the status here: https://github.com/samuela/nixpkgs-upkeep/actions

@drupol
Copy link
Contributor

drupol commented Sep 8, 2021

I opened an issue upstream: VSCodium/vscodium#828

@drupol
Copy link
Contributor

drupol commented Sep 10, 2021

Issue has been fixed, it should be ok now. @samuela could you trigger the CI?

Also, something to think about, VSCodium has been renamed into Codium, we should reflect that in Nixos.

@turion
Copy link
Contributor

turion commented Sep 10, 2021

Also, something to think about, VSCodium has been renamed into Codium, we should reflect that in Nixos.

What do you mean? Where is an official statement saying this? Or do you just mean the executable name? (The executable is codium since a longer time I think, reflecting that the VSCode executable is code.)

@drupol
Copy link
Contributor

drupol commented Sep 10, 2021

Also, something to think about, VSCodium has been renamed into Codium, we should reflect that in Nixos.

What do you mean? Where is an official statement saying this? Or do you just mean the executable name? (The executable is codium since a longer time I think, reflecting that the VSCode executable is code.)

Forget what I just said in my previous comment. I must have bugged somewhere :) Sorry !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants