Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.python-gvm: init at 21.6.0, python3Packages.gvm-tools: init at 21.6.1 #137031

Merged
merged 2 commits into from
Sep 11, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Sep 7, 2021

Motivation for this change

Collection of APIs that help with remote controlling a Greenbone Security Manager

https://github.com/greenbone/python-gvm

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member Author

fabaff commented Sep 7, 2021

Result of nixpkgs-review pr 137031 run on x86_64-linux 1

2 packages built:
  • python38Packages.python-gvm
  • python39Packages.python-gvm

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Sep 7, 2021
@risicle
Copy link
Contributor

risicle commented Sep 9, 2021

On macos 10.15:

__________________ GvmConnectionTestCase.test_feed_xml_error ___________________

self = <tests.connections.test_gvm_connection.GvmConnectionTestCase testMethod=test_feed_xml_error>

    def test_feed_xml_error(self):
        connection = GvmConnection()
        connection._start_xml()
        with self.assertRaises(
            GvmError, msg='Cannot parse XML response. Response data read bla'
        ):
>           connection._feed_xml("bla")

tests/connections/test_gvm_connection.py:58: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
gvm/connections.py:83: in _feed_xml
    self._parser.feed(data)
src/lxml/parser.pxi:1256: in lxml.etree._FeedParser.feed
    ???
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

>   ???
E   lxml.etree.ParserError: Unicode parsing is not supported on this platform

src/lxml/parser.pxi:1291: ParserError

@risicle
Copy link
Contributor

risicle commented Sep 9, 2021

Opened greenbone/python-gvm#550

This one looks like it's just an oversight in the test itself, so it should be fine to just skip this test on darwin.

@fabaff
Copy link
Member Author

fabaff commented Sep 10, 2021

This one looks like it's just an oversight in the test itself, so it should be fine to just skip this test on darwin.

Excluded on darwin.

@fabaff fabaff changed the title python3Packages.python-gvm: init at 21.6.0 python3Packages.python-gvm: init at 21.6.0, python3Packages.gvm-tools: init at 21.6.1 Sep 10, 2021
@fabaff
Copy link
Member Author

fabaff commented Sep 10, 2021

Result of nixpkgs-review pr 137031 run on x86_64-linux 1

4 packages built:
  • gvm-tools (python39Packages.gvm-tools)
  • python38Packages.gvm-tools
  • python38Packages.python-gvm
  • python39Packages.python-gvm

@SuperSandro2000 SuperSandro2000 merged commit 7c27cd6 into NixOS:master Sep 11, 2021
@fabaff fabaff deleted the python-gvm branch September 11, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants