haskell.packages.ghcjs.vector: Fix evaluation failure #150002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The derivation for the GHCJS `vector` package broke in NixOS#142940 due to introducing the line of code that this change deletes. The offending line appears to have been unintentionally added and causes an evaluation failure for two separate reason : * The argument order is wrong The change in NixOS#142940 switched the `haskellLib` utilities to flip their argument order, but the `appendPatch` in the offending line has the original argument order * The patch file referenced by the offending line does not exist The correct fix is to delete the line, because the patch is not necessary. The default version of the `vector` package is `0.12.3.1`, which already includes the fix from that patch.
Gabriella439
requested review from
cdepillabout,
maralorn and
sternenseemann
as code owners
ofborg
bot
added
10.rebuild-darwin: 0
|
cc @dfordivam |
Mic92
reviewed
Dec 10, 2021
|
FYI, this line was deleted here along with the patch -> #142689 |
|
@cdepillabout: Do I need to merge this into the |
|
Both should work, master is merged back into haskell-updates regularly.
… On 11. Dec 2021, at 17:45, Gabriella Gonzalez ***@***.***> wrote:
@cdepillabout: Do I need to merge this into the haskell-updates branch or do I merge this directly into master?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The derivation for the GHCJS
vectorpackage broke in #142940 due tointroducing the line of code that this change deletes.
The offending line appears to have been unintentionally added and
causes an evaluation failure for two separate reason :
The argument order is wrong
The change in Haskell: haskell.lib.composable init and switch #142940 switched the
haskellLibutilities to fliptheir argument order, but the
appendPatchin the offending linehas the original argument order
The patch file referenced by the offending line does not exist
The correct fix is to delete the line, because the patch is not
necessary. The default version of the
vectorpackage is0.12.3.1,which already includes the fix from that patch.