Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphene: 1.10.6 -> 1.10.8 #168087

Merged
merged 1 commit into from
Apr 19, 2022
Merged

graphene: 1.10.6 -> 1.10.8 #168087

merged 1 commit into from
Apr 19, 2022

Conversation

bobby285271
Copy link
Member

@bobby285271 bobby285271 commented Apr 10, 2022

Description of changes

https://github.com/ebassi/graphene/releases/tag/1.10.8
ebassi/graphene@1.10.6...1.10.8

I updated the patch because of ebassi/graphene@2a16dfa

Things done
  • On x86_64-linux:
    • Built graphene.passthru.tests gnome.mutter.passthru.tests on 83178f1b6ef26c825f43f7c5d95e253fd1f89cf3.
    • Built pkgsCross.aarch64-multiplatform.graphene on 3d00b96148da49d08641488ad9f6d67d904b86dc.

@bobby285271
Copy link
Member Author

bobby285271 commented Apr 10, 2022

For the darwin test failure, looks like there is ebassi/graphene#246 ("ray and simd tests fail on i686") 👀
Shall we patch away failing tests or just disable all tests or wait for upstream?

Update: patched away.

@ofborg ofborg bot requested review from dasj19, hedning, jtojnar and amaxine April 10, 2022 03:04
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 labels Apr 10, 2022
@jtojnar
Copy link
Member

jtojnar commented Apr 10, 2022

I am quite confused why are we doing all that variable renaming in the patch, instead of just changing the existing variables. The only benefit I see is that it would let us know when upstream added a new file to installed tests, since Meson would fail on referencing a non-existent variable – but we could achieve the same by just diffing the outputs.

@bobby285271
Copy link
Member Author

bobby285271 commented Apr 10, 2022

@ofborg build gnome.mutter338

@ofborg ofborg bot requested a review from jtojnar April 10, 2022 04:20
@bobby285271 bobby285271 merged commit 4edc1d2 into NixOS:master Apr 19, 2022
@bobby285271 bobby285271 deleted the graphene branch April 19, 2022 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants