Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.python-mapnik: fix build on x86_64 #231735

Merged
merged 3 commits into from
May 14, 2023

Conversation

Dettorer
Copy link
Contributor

Description of changes

For Python3.10: disable the OGR test, which fails since a gdal update at af10ec1 (Upstream tests are still considered unreliable according to mapnik/python-mapnik#255).

For Python3.11: use the 1.82 version of boost instead of the default 1.79. The import checks didn't pass because of a boost binding problem solved by boostorg/python#385.

ZHF: #230712

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
    • the few non-disabled tests of the upstream testsuite.
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.
nixpkgs-review output

Ran nix run '.#nixpkgs-review' -- rev HEAD --print-result

Result of nixpkgs-review run on x86_64-linux 1

4 packages built:
  • python310Packages.python-mapnik
  • python310Packages.python-mapnik.dist
  • python311Packages.python-mapnik
  • python311Packages.python-mapnik.dist

The OGR test fails since a gdal update at
af10ec1. Upstream tests are still
considered unreliable according to
mapnik/python-mapnik#255.
The import checks didn't pass because of a boost binding problem solved
by boostorg/python#385.
@Dettorer
Copy link
Contributor Author

@erictapen hi! I see you were the maintainer of this package in the past, would you still have time to review this fix? I also see you removed yourself from the maintainers list at some point so I'd understand if you didn't want to spend time on this. I'll ask someone else in a few days if needed and won't ping you again.

@mweinelt
Copy link
Member

Can you check the ofborg logs of the darwin builds? They have some broken tests, maybe they are salvagable.

@Dettorer Dettorer marked this pull request as draft May 14, 2023 10:42
@Dettorer Dettorer force-pushed the fix-mapnik branch 2 times, most recently from 6e61540 to 9f7d26a Compare May 14, 2023 14:31
- replace the hardcoded references to /tmp with $TMPDIR
- disable a PDF-related cairo test
@Dettorer Dettorer marked this pull request as ready for review May 14, 2023 17:13
@mweinelt mweinelt merged commit 9ab371d into NixOS:master May 14, 2023
@Dettorer
Copy link
Contributor Author

Dettorer commented May 14, 2023

Done, the tests were storing temporary files in hardcoded /tmp paths, which doesn't seem writable in the darwin nix sandbox, I added a pre-check step that replaces all occurrences of /tmp in the test files with $TMPDIR. I also disabled another test that was failing exclusively on darwin, I guess the discrepancy is caused by a different cairo implementation but I didn't really investigate.

@Dettorer Dettorer deleted the fix-mapnik branch May 15, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants