Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netclient: init at 0.21.0 #244197

Merged
merged 3 commits into from
Oct 9, 2023
Merged

netclient: init at 0.21.0 #244197

merged 3 commits into from
Oct 9, 2023

Conversation

wexder
Copy link
Contributor

@wexder wexder commented Jul 18, 2023

Description of changes

Added new package netclient https://github.com/gravitl/netclient

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` labels Jul 18, 2023
@wexder wexder force-pushed the netclient branch 2 times, most recently from 5e33bb4 to b6843b0 Compare July 18, 2023 17:41
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 labels Jul 18, 2023
Gerg-L
Gerg-L suggested changes Jul 18, 2023
View reviewed changes
nixos/modules/services/networking/netclient.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/netclient.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/netclient.nix Show resolved Hide resolved
nixos/modules/services/networking/netclient.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/netclient.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/netclient/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/netclient/default.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/netclient.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/netclient.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/netclient/default.nix Outdated Show resolved Hide resolved
@wexder wexder force-pushed the netclient branch 2 times, most recently from c6e44cb to d2864c3 Compare July 21, 2023 18:47
@GiggleSquid GiggleSquid added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jul 22, 2023
@GiggleSquid
Copy link
Contributor

Result of nixpkgs-review pr 244197 run on x86_64-linux 1

2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
1 package built:
  • netclient

@wexder wexder force-pushed the netclient branch 2 times, most recently from 21524d6 to 61f9ce3 Compare July 27, 2023 16:03
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jul 29, 2023
@Lord-Valen Lord-Valen added 8.has: module (new) This PR adds a module in `nixos/` and removed 8.has: module (update) This PR changes an existing module in `nixos/` labels Aug 28, 2023
@github-actions github-actions bot added the 8.has: module (update) This PR changes an existing module in `nixos/` label Aug 31, 2023
@wexder wexder force-pushed the netclient branch 4 times, most recently from 373dc68 to 16cdd8a Compare September 16, 2023 10:19
@wexder wexder changed the title netclient: init at 0.20.6 netclient: init at 0.21.0 Sep 16, 2023
@wexder
Copy link
Contributor Author

wexder commented Sep 16, 2023

@ofborg build netclient

@wexder
Copy link
Contributor Author

wexder commented Sep 16, 2023

Ah, it was for passthru.tests. The actual problem:

# golang.design/x/clipboard
vendor/golang.design/x/clipboard/clipboard_darwin.go:16:9: fatal error: 'Cocoa/Cocoa.h' file not found
#import <Cocoa/Cocoa.h>
        ^~~~~~~~~~~~~~~
1 error generated.
error: builder for '/nix/store/8qpa4gphzlvhbi1s6zcavml034zw4r1a-netclient-0.20.6.drv' failed with exit code 1;
       last 10 log lines:
       > Building subPackage ./config
       > Building subPackage ./daemon
       > Building subPackage ./firewall
       > Building subPackage ./functions
       > Building subPackage ./gui
       > # golang.design/x/clipboard
       > vendor/golang.design/x/clipboard/clipboard_darwin.go:16:9: fatal error: 'Cocoa/Cocoa.h' file not found
       > #import <Cocoa/Cocoa.h>
       >         ^~~~~~~~~~~~~~~
       > 1 error generated.
       For full logs, run 'nix log /nix/store/8qpa4gphzlvhbi1s6zcavml034zw4r1a-netclient-0.20.6.drv'.

@Lord-Valen Can you please take a look if the buildInputs looks good. It makes sense to me to have it like this, but it might not be the correct way

@Gerg-L
Copy link
Contributor

Gerg-L commented Sep 22, 2023

LGTM

@Gerg-L Gerg-L added the 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people label Sep 22, 2023
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1135

@purepani
Copy link
Contributor

purepani commented Oct 8, 2023

@wegank Do you think you can merge this?

@Gerg-L
Copy link
Contributor

Gerg-L commented Oct 8, 2023

@wexder you have merge conflicts

@wexder
Copy link
Contributor Author

wexder commented Oct 9, 2023

@wegank thank you for resolving merge conflicts

@wegank wegank merged commit ad85537 into NixOS:master Oct 9, 2023
24 checks passed
@wexder wexder deleted the netclient branch October 13, 2023 19:22
@wexder wexder mentioned this pull request Oct 13, 2023
Closed
@pizzaandcheese pizzaandcheese mentioned this pull request Dec 12, 2023
Closed
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/netmaker-options/36906/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gerg-L Gerg-L Gerg-L approved these changes

@Lord-Valen Lord-Valen Lord-Valen approved these changes

@wegank wegank wegank approved these changes

@GiggleSquid GiggleSquid GiggleSquid approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@wexder @GiggleSquid @Lord-Valen @Gerg-L @nixos-discourse @purepani @wegank @Janik-Haag