freetube: 0.18.0 -> 0.19.0

[LAURAilway]

Description of changes

freetube: 0.18.0 -> 0.19.0
https://github.com/FreeTubeApp/FreeTube/releases/tag/v0.19.0-beta

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[natsukium]

Thanks for your contribution!

Would you please read CONTRIBUTING.md (especially https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#commit-conventions) and rewrite your commit message?
Thanks.

[LAURAilway]

Thanks for your contribution!

Would you please read CONTRIBUTING.md (especially https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#commit-conventions) and rewrite your commit message? Thanks.

Like this?

[natsukium]

That's great.
Could you change the commit message as well?

[natsukium]

Result of nixpkgs-review pr 250484 run on x86_64-linux 1

1 package built:

• freetube

[LAURAilway]

That's great. Could you change the commit message as well?

Is this what you meant? (Sorry, first commit and very tired)

[natsukium]

Don't worry.

I think this page is helpful for you.
https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/changing-a-commit-message

The commit message is what is shown here as Updated freetube derivation to version 0.19.0.
To change it to freetube: 0.18.0 -> 0.19.0, please execute git commit --amend on your local repository.

[natsukium]

LGTM, thanks!

[absidue]

Hi I'm one of the people on the FreeTube team and 3 people (including the author of this pull request) have reported that your FreeTube package is broken, but don't have issues using our official releases: FreeTubeApp/FreeTube#3953.

I don't know much about NixOS and it's packaging, however looking at your FreeTube packaging file, it looks like you are extracting our AppImage that was built with/for Electron 22.3.18 but running it with your own much newer Electron version.

[absidue]

The reason I suspect the Electron mismatch is the problem, is that the unofficial AUR package had issues in the past, that were caused by using a different version of Electron to upstream.

[ryneeverett]

It would be easy enough to switch from electron to electron_22, but I can't reproduce the reported bugs on wayland+sway.

[LAURAilway]

The reason I suspect the Electron mismatch is the problem, is that the unofficial AUR package had issues in the past, that were caused by using a different version of Electron to upstream.

Thanks for the suggestion, should be fixed by #252061
(and in case anyone was curious, the default electron version was updated to 26 at pretty much the same time the FreeTube update was merged, so during testing, the electron version was still compatible)

[natsukium]

It works on my Weston (WSL) and hyprland regardless of the version of electron.
Does pinning electron to 22 actually fix the reported bug?

[LAURAilway]

It works on my Weston (WSL) and hyprland regardless of the version of electron. Does pinning electron to 22 actually fix the reported bug?

It does fix it on my end, I don't have anyone else to test it tho